minor #33770 Add types to constructors and private/final/internal methods (Batch III) (derrabus)

This PR was squashed before being merged into the 4.4 branch (closes #33770).

Discussion
----------

Add types to constructors and private/final/internal methods (Batch III)

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | #32179, #33228
| License       | MIT
| Doc PR        | N/A

Followup to #33709, this time with:
* Validator
* VarDumper
* Workflow
* Yaml
* all bridges
* all bundles

That should be the final batch. 😃

Commits
-------

6493902287 Add types to constructors and private/final/internal methods (Batch III)

Author: nicolas-grekas

Command/DebugCommand.php

@@ -364,7 +364,7 @@ private function getMetadata(string $type, $entity)
         return null;
     }
 
-    private function getPrettyMetadata(string $type, $entity, bool $decorated)
+    private function getPrettyMetadata(string $type, $entity, bool $decorated): ?string
     {
         if ('tests' === $type) {
             return '';

Command/LintCommand.php

@@ -119,7 +119,7 @@ private function getStdin(): string
         return $template;
     }
 
-    private function getFilesInfo(array $filenames)
+    private function getFilesInfo(array $filenames): array
     {
         $filesInfo = [];
         foreach ($filenames as $filename) {

Extension/CodeExtension.php

@@ -236,7 +236,7 @@ public function formatFileFromText($text)
     /**
      * @internal
      */
-    public function formatLogMessage($message, array $context)
+    public function formatLogMessage(string $message, array $context): string
     {
         if ($context && false !== strpos($message, '{')) {
             $replacements = [];

Extension/FormExtension.php

@@ -111,7 +111,7 @@ public function getName()
  *
  * @see ChoiceView::isSelected()
  */
-function twig_is_selected_choice(ChoiceView $choice, $selectedValue)
+function twig_is_selected_choice(ChoiceView $choice, $selectedValue): bool
 {
     if (\is_array($selectedValue)) {
         return \in_array($choice->value, $selectedValue, true);
@@ -123,7 +123,7 @@ function twig_is_selected_choice(ChoiceView $choice, $selectedValue)
 /**
  * @internal
  */
-function twig_is_root_form(FormView $formView)
+function twig_is_root_form(FormView $formView): bool
 {
     return null === $formView->parent;
 }

NodeVisitor/TranslationDefaultDomainNodeVisitor.php

@@ -132,7 +132,7 @@ private function isNamedArguments(Node $arguments): bool
         return false;
     }
 
-    private function getVarName()
+    private function getVarName(): string
     {
         return sprintf('__internal_%s', hash('sha256', uniqid(mt_rand(), true), false));
     }

UndefinedCallableHandler.php

@@ -65,7 +65,7 @@ class UndefinedCallableHandler
         'workflow' => 'enable "framework.workflows"',
     ];
 
-    public static function onUndefinedFilter($name)
+    public static function onUndefinedFilter(string $name): bool
     {
         if (!isset(self::$filterComponents[$name])) {
             return false;
@@ -76,7 +76,7 @@ public static function onUndefinedFilter($name)
         return true;
     }
 
-    public static function onUndefinedFunction($name)
+    public static function onUndefinedFunction(string $name): bool
     {
         if (!isset(self::$functionComponents[$name])) {
             return false;
@@ -87,7 +87,7 @@ public static function onUndefinedFunction($name)
         return true;
     }
 
-    private static function onUndefined($name, $type, $component)
+    private static function onUndefined(string $name, string $type, string $component)
     {
         if (class_exists(FullStack::class) && isset(self::$fullStackEnable[$component])) {
             throw new SyntaxError(sprintf('Did you forget to %s? Unknown %s "%s".', self::$fullStackEnable[$component], $type, $name));