[Translation] Extract translatable content on twig set

Author: Nate Wiebe

NodeVisitor/TranslationNodeVisitor.php

@@ -69,12 +69,10 @@ protected function doEnterNode(Node $node, Environment $env): Node
                 $this->getReadDomainFromArguments($node->getNode('arguments'), 1),
             ];
         } elseif (
-            $node instanceof FilterExpression &&
-            'trans' === $node->getNode('filter')->getAttribute('value') &&
-            $node->getNode('node') instanceof FunctionExpression &&
-            't' === $node->getNode('node')->getAttribute('name')
+            $node instanceof FunctionExpression &&
+            't' === $node->getAttribute('name')
         ) {
-            $nodeArguments = $node->getNode('node')->getNode('arguments');
+            $nodeArguments = $node->getNode('arguments');
 
             if ($nodeArguments->getIterator()->current() instanceof ConstantExpression) {
                 $this->messages[] = [

Tests/Translation/TwigExtractorTest.php

@@ -66,6 +66,7 @@ public function getExtractData()
             ['{% set foo = "new key" | trans %}', ['new key' => 'messages']],
             ['{{ 1 ? "new key" | trans : "another key" | trans }}', ['new key' => 'messages', 'another key' => 'messages']],
             ['{{ t("new key") | trans() }}', ['new key' => 'messages']],
+            ['{% set foo = t("new key") %}', ['new key' => 'messages']],
             ['{{ t("new key", {}, "domain") | trans() }}', ['new key' => 'domain']],
             ['{{ 1 ? t("new key") | trans : t("another key") | trans }}', ['new key' => 'messages', 'another key' => 'messages']],