Clean skippable tests that are never skipped

Author: fancyweb

Tests/Command/DebugCommandTest.php

@@ -299,10 +299,6 @@ public function testWithFilter()
      */
     public function testComplete(array $input, array $expectedSuggestions)
     {
-        if (!class_exists(CommandCompletionTester::class)) {
-            $this->markTestSkipped('Test command completion requires symfony/console 5.4+.');
-        }
-
         $projectDir = \dirname(__DIR__).\DIRECTORY_SEPARATOR.'Fixtures';
         $loader = new FilesystemLoader([], $projectDir);
         $environment = new Environment($loader);

Tests/Command/LintCommandTest.php

@@ -141,10 +141,6 @@ public function testLintAutodetectsGithubActionEnvironment()
      */
     public function testComplete(array $input, array $expectedSuggestions)
     {
-        if (!class_exists(CommandCompletionTester::class)) {
-            $this->markTestSkipped('Test command completion requires symfony/console 5.4+.');
-        }
-
         $tester = new CommandCompletionTester($this->createCommand());
 
         $this->assertSame($expectedSuggestions, $tester->complete($input));

Tests/Extension/HttpFoundationExtensionTest.php

@@ -60,10 +60,6 @@ public function getGenerateAbsoluteUrlData()
      */
     public function testGenerateAbsoluteUrlWithRequestContext($path, $baseUrl, $host, $scheme, $httpPort, $httpsPort, $expected)
     {
-        if (!class_exists(RequestContext::class)) {
-            $this->markTestSkipped('The Routing component is needed to run tests that depend on its request context.');
-        }
-
         $requestContext = new RequestContext($baseUrl, 'GET', $host, $scheme, $httpPort, $httpsPort, $path);
         $extension = new HttpFoundationExtension(new UrlHelper(new RequestStack(), $requestContext));
 
@@ -75,10 +71,6 @@ public function testGenerateAbsoluteUrlWithRequestContext($path, $baseUrl, $host
      */
     public function testGenerateAbsoluteUrlWithoutRequestAndRequestContext($path)
     {
-        if (!class_exists(RequestContext::class)) {
-            $this->markTestSkipped('The Routing component is needed to run tests that depend on its request context.');
-        }
-
         $extension = new HttpFoundationExtension(new UrlHelper(new RequestStack()));
 
         $this->assertEquals($path, $extension->generateAbsoluteUrl($path));
@@ -118,10 +110,6 @@ public function testGenerateAbsoluteUrlWithScriptFileName()
      */
     public function testGenerateRelativePath($expected, $path, $pathinfo)
     {
-        if (!method_exists(Request::class, 'getRelativeUriForPath')) {
-            $this->markTestSkipped('Your version of Symfony HttpFoundation is too old.');
-        }
-
         $stack = new RequestStack();
         $stack->push(Request::create($pathinfo));
         $extension = new HttpFoundationExtension(new UrlHelper($stack));

Tests/Extension/HttpKernelExtensionTest.php

@@ -58,10 +58,6 @@ public function testUnknownFragmentRenderer()
 
     public function testGenerateFragmentUri()
     {
-        if (!class_exists(FragmentUriGenerator::class)) {
-            $this->markTestSkipped('HttpKernel 5.3+ is required');
-        }
-
         $requestStack = new RequestStack();
         $requestStack->push(Request::create('/'));
 

Tests/Extension/WorkflowExtensionTest.php

@@ -30,10 +30,6 @@ class WorkflowExtensionTest extends TestCase
 
     protected function setUp(): void
     {
-        if (!class_exists(Workflow::class)) {
-            $this->markTestSkipped('The Workflow component is needed to run tests for this extension.');
-        }
-
         $places = ['ordered', 'waiting_for_payment', 'processed'];
         $transitions = [
             $this->t1 = new Transition('t1', 'ordered', 'waiting_for_payment'),
@@ -110,9 +106,6 @@ public function testGetMarkedPlaces()
 
     public function testGetMetadata()
     {
-        if (!class_exists(InMemoryMetadataStore::class)) {
-            $this->markTestSkipped('This test requires symfony/workflow:4.1.');
-        }
         $subject = new Subject();
 
         $this->assertSame('workflow title', $this->extension->getMetadata($subject, 'title'));
@@ -124,9 +117,6 @@ public function testGetMetadata()
 
     public function testbuildTransitionBlockerList()
     {
-        if (!class_exists(TransitionBlockerList::class)) {
-            $this->markTestSkipped('This test requires symfony/workflow:4.1.');
-        }
         $subject = new Subject();
 
         $list = $this->extension->buildTransitionBlockerList($subject, 't1');