Skip to content

Commit 7a5ce12

Browse files
committed
bug #24837 [TwigBridge] [Bootstrap 4] Fix validation error design for expanded choiceType (ostrolucky)
This PR was merged into the 3.4 branch. Discussion ---------- [TwigBridge] [Bootstrap 4] Fix validation error design for expanded choiceType | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Unfortunately I didn't test symfony/symfony#24802 with expanded option set to true, sorry about that. Without this fix, it applies form error style twice. Before: ![screenshot from 2017-11-06 10 31 55](https://user-images.githubusercontent.com/496233/32434235-c13c02f8-c2dd-11e7-97da-6bfa312c5825.png) After: ![screenshot from 2017-11-06 10 32 40](https://user-images.githubusercontent.com/496233/32434252-d30c2224-c2dd-11e7-86d6-fd06af3ef753.png) Commits ------- 39083a2067 [TwigBridge] [Bootstrap 4] Fix validation error design for expanded choiceType
2 parents 0997528 + 062d6d6 commit 7a5ce12

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Resources/views/Form/bootstrap_4_layout.html.twig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@
111111
{{- form_widget(child, {
112112
parent_label_class: label_attr.class|default(''),
113113
translation_domain: choice_translation_domain,
114-
valid: valid,
114+
valid: true,
115115
}) -}}
116116
{% endfor -%}
117117
</div>

0 commit comments

Comments
 (0)