Merge branch '4.4' into 5.2

* 4.4:
  Fix #36973: Command description consistency
  Render email once

Author: fabpot

Command/DebugCommand.php

@@ -60,7 +60,7 @@ protected function configure()
                 new InputOption('filter', null, InputOption::VALUE_REQUIRED, 'Show details for all entries matching this filter'),
                 new InputOption('format', null, InputOption::VALUE_REQUIRED, 'The output format (text or json)', 'text'),
             ])
-            ->setDescription('Shows a list of twig functions, filters, globals and tests')
+            ->setDescription('Show a list of twig functions, filters, globals and tests')
             ->setHelp(<<<'EOF'
 The <info>%command.name%</info> command outputs a list of twig functions,
 filters, globals and tests.

Command/LintCommand.php

@@ -48,7 +48,7 @@ public function __construct(Environment $twig)
     protected function configure()
     {
         $this
-            ->setDescription('Lints a template and outputs encountered errors')
+            ->setDescription('Lint a template and outputs encountered errors')
             ->addOption('format', null, InputOption::VALUE_REQUIRED, 'The output format', 'txt')
             ->addOption('show-deprecations', null, InputOption::VALUE_NONE, 'Show deprecations as errors')
             ->addArgument('filename', InputArgument::IS_ARRAY, 'A file, a directory or "-" for reading from STDIN')

Mime/BodyRenderer.php

@@ -46,6 +46,14 @@ public function render(Message $message): void
         }
 
         $messageContext = $message->getContext();
+
+        $previousRenderingKey = $messageContext[__CLASS__] ?? null;
+        unset($messageContext[__CLASS__]);
+        $currentRenderingKey = md5(serialize([$messageContext, $message->getTextTemplate(), $message->getHtmlTemplate()]));
+        if ($previousRenderingKey === $currentRenderingKey) {
+            return;
+        }
+
         if (isset($messageContext['email'])) {
             throw new InvalidArgumentException(sprintf('A "%s" context cannot have an "email" entry as this is a reserved variable.', get_debug_type($message)));
         }
@@ -66,6 +74,7 @@ public function render(Message $message): void
         if (!$message->getTextBody() && null !== $html = $message->getHtmlBody()) {
             $message->text($this->convertHtmlToText(\is_resource($html) ? stream_get_contents($html) : $html));
         }
+        $message->context($message->getContext() + [__CLASS__ => $currentRenderingKey]);
     }
 
     private function convertHtmlToText(string $html): string

Tests/Mime/BodyRendererTest.php

@@ -79,6 +79,27 @@ public function testRenderWithContextReservedEmailEntry()
         $this->prepareEmail('Text', '', ['email' => 'reserved!']);
     }
 
+    public function testRenderedOnce()
+    {
+        $twig = new Environment(new ArrayLoader([
+            'text' => 'Text',
+        ]));
+        $renderer = new BodyRenderer($twig);
+        $email = (new TemplatedEmail())
+            ->to('[email protected]')
+            ->from('[email protected]')
+        ;
+        $email->textTemplate('text');
+
+        $renderer->render($email);
+        $this->assertEquals('Text', $email->getTextBody());
+
+        $email->text('reset');
+
+        $renderer->render($email);
+        $this->assertEquals('reset', $email->getTextBody());
+    }
+
     private function prepareEmail(?string $text, ?string $html, array $context = []): TemplatedEmail
     {
         $twig = new Environment(new ArrayLoader([