[Tests] Move expectException closer to the place of the expectation to avoid false positives

OskarStark · OskarStark · commit a20c7aa64902 · 2023-10-31T09:40:20.000+01:00
diff --git a/Tests/Extension/HttpKernelExtensionTest.php b/Tests/Extension/HttpKernelExtensionTest.php
@@ -30,9 +30,10 @@ class HttpKernelExtensionTest extends TestCase
 {
     public function testFragmentWithError()
     {
-        $this->expectException(\Twig\Error\RuntimeError::class);
         $renderer = $this->getFragmentHandler($this->throwException(new \Exception('foo')));
 
+        $this->expectException(\Twig\Error\RuntimeError::class);
+
         $this->renderTemplate($renderer);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -30,9 +30,10 @@ class HttpKernelExtensionTest extends TestCase`
`30`	`30`	`{`
`31`	`31`	`public function testFragmentWithError()`
`32`	`32`	`{`
`33`		`- $this->expectException(\Twig\Error\RuntimeError::class);`
`34`	`33`	`$renderer = $this->getFragmentHandler($this->throwException(new \Exception('foo')));`
`35`	`34`
	`35`	`+ $this->expectException(\Twig\Error\RuntimeError::class);`
	`36`	`+`
`36`	`37`	`$this->renderTemplate($renderer);`
`37`	`38`	`}`
`38`	`39`