Remove return type for Twig function workflow_metadata()

gisostallenberg · gisostallenberg · commit d64035d0d6b3 · 2020-04-14T11:16:32.000+02:00
Technically it is allowed to have metadata other than string, even data that does not cast to string, like an array. Also see symfony/symfony#36391
diff --git a/Extension/WorkflowExtension.php b/Extension/WorkflowExtension.php
@@ -117,7 +117,7 @@ public function getMarkedPlaces($subject, $placesNameOnly = true, $name = null)
      *                                                Use a string (the place name) to get place metadata
      *                                                Use a Transition instance to get transition metadata
      */
-    public function getMetadata($subject, string $key, $metadataSubject = null, string $name = null): ?string
+    public function getMetadata($subject, string $key, $metadataSubject = null, string $name = null)
     {
         return $this
             ->workflowRegistry

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ public function getMarkedPlaces($subject, $placesNameOnly = true, $name = null)`
`117`	`117`	`* Use a string (the place name) to get place metadata`
`118`	`118`	`* Use a Transition instance to get transition metadata`
`119`	`119`	`*/`
`120`		`- public function getMetadata($subject, string $key, $metadataSubject = null, string $name = null): ?string`
	`120`	`+ public function getMetadata($subject, string $key, $metadataSubject = null, string $name = null)`
`121`	`121`	`{`
`122`	`122`	`return $this`
`123`	`123`	`->workflowRegistry`