Merge branch '5.4' into 6.2

* 5.4:
  Migrate to `static` data providers using `rector/rector`

Author: nicolas-grekas

Tests/AppVariableTest.php

@@ -43,7 +43,7 @@ public function testDebug($debugFlag)
         $this->assertEquals($debugFlag, $this->appVariable->getDebug());
     }
 
-    public function debugDataProvider()
+    public static function debugDataProvider()
     {
         return [
             'debug on' => [true],

Tests/Command/DebugCommandTest.php

@@ -84,7 +84,7 @@ public function testDebugTemplateName(array $input, string $output, array $paths
         $this->assertStringMatchesFormat($output, $tester->getDisplay(true));
     }
 
-    public function getDebugTemplateNameTestData()
+    public static function getDebugTemplateNameTestData()
     {
         $defaultPaths = [
             'templates/' => null,
@@ -311,7 +311,7 @@ public function testComplete(array $input, array $expectedSuggestions)
         $this->assertSame($expectedSuggestions, $suggestions);
     }
 
-    public function provideCompletionSuggestions(): iterable
+    public static function provideCompletionSuggestions(): iterable
     {
         yield 'name' => [['email'], []];
         yield 'option --format' => [['--format', ''], ['text', 'json']];

Tests/Command/LintCommandTest.php

@@ -146,7 +146,7 @@ public function testComplete(array $input, array $expectedSuggestions)
         $this->assertSame($expectedSuggestions, $tester->complete($input));
     }
 
-    public function provideCompletionSuggestions()
+    public static function provideCompletionSuggestions()
     {
         yield 'option' => [['--format', ''], ['txt', 'json', 'github']];
     }

Tests/Extension/CodeExtensionTest.php

@@ -44,15 +44,15 @@ public function testGettingMethodAbbreviation($method, $abbr)
         $this->assertEquals($this->getExtension()->abbrMethod($method), $abbr);
     }
 
-    public function getClassNameProvider(): array
+    public static function getClassNameProvider(): array
     {
         return [
             ['F\Q\N\Foo', '<abbr title="F\Q\N\Foo">Foo</abbr>'],
             ['Bare', '<abbr title="Bare">Bare</abbr>'],
         ];
     }
 
-    public function getMethodNameProvider(): array
+    public static function getMethodNameProvider(): array
     {
         return [
             ['F\Q\N\Foo::Method', '<abbr title="F\Q\N\Foo">Foo</abbr>::Method()'],

Tests/Extension/DumpExtensionTest.php

@@ -53,7 +53,7 @@ public function testDumpTag($template, $debug, $expectedOutput, $expectedDumped)
         $this->assertSame($expectedDumped, $dumped);
     }
 
-    public function getDumpTags()
+    public static function getDumpTags()
     {
         return [
             ['A{% dump %}B', true, 'AB', []],
@@ -88,7 +88,7 @@ public function testDump($context, $args, $expectedOutput, $debug = true)
         $this->assertEquals($expectedOutput, $dump);
     }
 
-    public function getDumpArgs()
+    public static function getDumpArgs()
     {
         return [
             [[], [], '', false],

Tests/Extension/FormExtensionDivLayoutTest.php

@@ -100,7 +100,7 @@ public function testThemeBlockInheritanceUsingDynamicExtend()
         );
     }
 
-    public function isSelectedChoiceProvider()
+    public static function isSelectedChoiceProvider()
     {
         return [
             [true, '0', '0'],
@@ -150,7 +150,7 @@ public function testStartTagHasActionAttributeWhenActionIsZero()
         $this->assertSame('<form name="form" method="get" action="0">', $html);
     }
 
-    public function isRootFormProvider()
+    public static function isRootFormProvider()
     {
         return [
             [true, new FormView()],

Tests/Extension/HttpFoundationExtensionTest.php

@@ -32,7 +32,7 @@ public function testGenerateAbsoluteUrl($expected, $path, $pathinfo)
         $this->assertEquals($expected, $extension->generateAbsoluteUrl($path));
     }
 
-    public function getGenerateAbsoluteUrlData()
+    public static function getGenerateAbsoluteUrlData()
     {
         return [
             ['http://localhost/foo.png', '/foo.png', '/foo/bar.html'],
@@ -76,7 +76,7 @@ public function testGenerateAbsoluteUrlWithoutRequestAndRequestContext($path)
         $this->assertEquals($path, $extension->generateAbsoluteUrl($path));
     }
 
-    public function getGenerateAbsoluteUrlRequestContextData()
+    public static function getGenerateAbsoluteUrlRequestContextData()
     {
         return [
             ['/foo.png', '/foo', 'localhost', 'http', 80, 443, 'http://localhost/foo.png'],
@@ -117,7 +117,7 @@ public function testGenerateRelativePath($expected, $path, $pathinfo)
         $this->assertEquals($expected, $extension->generateRelativePath($path));
     }
 
-    public function getGenerateRelativePathData()
+    public static function getGenerateRelativePathData()
     {
         return [
             ['../foo.png', '/foo.png', '/foo/bar.html'],

Tests/Extension/RoutingExtensionTest.php

@@ -34,7 +34,7 @@ public function testEscaping($template, $mustBeEscaped)
         $this->assertSame($mustBeEscaped, $nodes->getNode('body')->getNode(0)->getNode('expr') instanceof FilterExpression);
     }
 
-    public function getEscapingTemplates()
+    public static function getEscapingTemplates()
     {
         return [
             ['{{ path("foo") }}', false],

Tests/Extension/SerializerExtensionTest.php

@@ -41,7 +41,7 @@ public function testSerializeFilter(string $template, string $expectedResult)
         self::assertSame($expectedResult, $twig->render('template', ['object' => new SerializerModelFixture()]));
     }
 
-    public function serializerDataProvider(): \Generator
+    public static function serializerDataProvider(): \Generator
     {
         yield ['{{ object|serialize }}', '{"name":"howdy","title":"fixture"}'];
         yield ['{{ object|serialize(\'yaml\') }}', '{ name: howdy, title: fixture }'];

Tests/Extension/StopwatchExtensionTest.php

@@ -41,7 +41,7 @@ public function testTiming($template, $events)
         }
     }
 
-    public function getTimingTemplates()
+    public static function getTimingTemplates()
     {
         return [
             ['{% stopwatch "foo" %}something{% endstopwatch %}', 'foo'],