feature #3103 [Autocomplete] Remove deprecated code for 3.0 (smnandre)

This PR was merged into the 3.x branch.

Discussion
----------

[Autocomplete] Remove deprecated code for 3.0

| Q              | A
| -------------- | ---
| Bug fix?       | no
| New feature?   | no
| Deprecations?  | no
| Documentation? | no
| Issues         | Fix #...
| License        | MIT

src/Autocomplete/src/Form/ParentEntityAutocompleteType.php:27
```php
        `@deprecated` since Symfony UX 2.13, use "Symfony\UX\Autocomplete\Form\BaseEntityAutocompleteType" instead
```

src/Autocomplete/src/Form/ChoiceList/Loader/ExtraLazyChoiceLoader.php:21
```php
        `@deprecated` since Symfony UX 2.23 and will be removed in 3.0, use Symfony\Component\Form\ChoiceList\Loader\LazyChoiceLoader instead.
```

src/Autocomplete/src/Form/AutocompleteEntityTypeSubscriber.php:26
```php
        `@deprecated` since Symfony UX 2.13
```

src/Autocomplete/src/Doctrine/EntityMetadata.php:47
```php
    trigger_deprecation('symfony/ux-autocomplete', '2.15.0', 'Calling EntityMetadata::getPropertyMetadata() is deprecated. You should stop using it, as it will be removed in the future.');
```

src/Autocomplete/src/AutocompleteResultsExecutor.php:38
```php
    trigger_deprecation('symfony/ux-autocomplete', '2.8.0', 'Passing a "%s" instance as the second argument of "%s()" is deprecated, pass a "%s" instance instead.', Security::class, __METHOD__, PropertyAccessorInterface::class);
```

Commits
-------

532a5e1 [Autocomplete] Remove deprecations for 3.0

Author: Kocal

UPGRADE-3.0.md

@@ -10,6 +10,30 @@ the [Symfony documentation](https://symfony.com/doc/6.4/setup/upgrade_major.html
 >
 > Requires Symfony `6.4` or higher.
 
+## Autocomplete
+
+* The class `ParentEntityAutocompleteType` has been removed in favor of `BaseEntityAutocompleteType`:
+```diff
+-use Symfony\UX\Autocomplete\Form\ParentEntityAutocompleteType;
++use Symfony\UX\Autocomplete\Form\BaseEntityAutocompleteType;
+
+    #[AsEntityAutocompleteField]
+    class FoodAutocompleteField extends AbstractType
+    {
+        // ...
+
+        public function getParent(): string
+        {
+-           return ParentEntityAutocompleteType::class;
++           return BaseEntityAutocompleteType::class;
+        }
+    }
+```
+
+* The class `ExtraLazyChoiceLoader` has been removed in favor of
+  `Symfony\Component\Form\ChoiceList\Loader\LazyChoiceLoader` from Symfony Form >=7.2,
+  run `composer require symfony/form:>=7.2"` if you don't have it installed yet.
+
 ## LazyImage
 
 * The package has been removed, see the [previous README](https://raw.githubusercontent.com/symfony/ux/refs/heads/2.x/src/LazyImage/README.md)

src/Autocomplete/CHANGELOG.md

@@ -4,6 +4,9 @@
 
 -   Minimum required Symfony version is now 6.4
 -   Minimum required PHP version is now 8.2
+-   Remove `ParentEntityAutocompleteType` in favor of `BaseEntityAutocompleteType`
+-   Remove `ExtraLazyChoiceLoader` in favor of `Symfony\Component\Form\ChoiceList\Loader\LazyChoiceLoader` from Symfony Form >=7.2
+-   Add parameter `$security` to `AutocompleteResultsExecutor::__construct()`
 
 ## 2.30
 

src/Autocomplete/composer.json

@@ -37,7 +37,7 @@
         "doctrine/orm": "^2.9.4|^3.0",
         "fakerphp/faker": "^1.22",
         "mtdowling/jmespath.php": "^2.6",
-        "symfony/form": "^6.4|^7.0|^8.0",
+        "symfony/form": "^7.2|^8.0",
         "symfony/options-resolver": "^6.4|^7.0|^8.0",
         "symfony/framework-bundle": "^6.4|^7.0|^8.0",
         "symfony/maker-bundle": "^1.40",

src/Autocomplete/src/AutocompleteResultsExecutor.php

@@ -14,7 +14,6 @@
 use Doctrine\ORM\Tools\Pagination\Paginator;
 use Symfony\Bundle\SecurityBundle\Security;
 use Symfony\Component\PropertyAccess\Exception\UnexpectedTypeException;
-use Symfony\Component\PropertyAccess\PropertyAccessor;
 use Symfony\Component\PropertyAccess\PropertyAccessorInterface;
 use Symfony\Component\PropertyAccess\PropertyPath;
 use Symfony\Component\PropertyAccess\PropertyPathInterface;
@@ -26,22 +25,11 @@
  */
 final class AutocompleteResultsExecutor
 {
-    private PropertyAccessorInterface $propertyAccessor;
-    private ?Security $security;
-
     public function __construct(
         private DoctrineRegistryWrapper $managerRegistry,
-        $propertyAccessor,
-        /* Security $security = null */
+        private PropertyAccessorInterface $propertyAccessor,
+        private ?Security $security = null,
     ) {
-        if ($propertyAccessor instanceof Security) {
-            trigger_deprecation('symfony/ux-autocomplete', '2.8.0', 'Passing a "%s" instance as the second argument of "%s()" is deprecated, pass a "%s" instance instead.', Security::class, __METHOD__, PropertyAccessorInterface::class);
-            $this->security = $propertyAccessor;
-            $this->propertyAccessor = new PropertyAccessor();
-        } else {
-            $this->propertyAccessor = $propertyAccessor;
-            $this->security = \func_num_args() >= 3 ? func_get_arg(2) : null;
-        }
     }
 
     public function fetchResults(EntityAutocompleterInterface $autocompleter, string $query, int $page): AutocompleteResults

src/Autocomplete/src/DependencyInjection/AutocompleteExtension.php

@@ -29,7 +29,6 @@
 use Symfony\UX\Autocomplete\Form\AsEntityAutocompleteField;
 use Symfony\UX\Autocomplete\Form\AutocompleteChoiceTypeExtension;
 use Symfony\UX\Autocomplete\Form\BaseEntityAutocompleteType;
-use Symfony\UX\Autocomplete\Form\ParentEntityAutocompleteType;
 use Symfony\UX\Autocomplete\Form\WrappedEntityTypeAutocompleter;
 use Symfony\UX\Autocomplete\Maker\MakeAutocompleteField;
 
@@ -147,14 +146,6 @@ private function registerFormServices(ContainerBuilder $container): void
             ])
             ->addTag('form.type');
 
-        $container
-            ->register('ux.autocomplete.entity_type', ParentEntityAutocompleteType::class)
-            ->setDeprecated('symfony/ux-autocomplete', '2.13', 'The "%service_id%" form type is deprecated since 2.13. Use "ux.autocomplete.base_entity_type" instead.')
-            ->setArguments([
-                new Reference('router'),
-            ])
-            ->addTag('form.type');
-
         $container
             ->register('ux.autocomplete.choice_type_extension', AutocompleteChoiceTypeExtension::class)
             ->setArguments([

src/Autocomplete/src/Doctrine/EntityMetadata.php

@@ -42,17 +42,6 @@ public function isEmbeddedClassProperty(string $propertyName): bool
         return \array_key_exists($propertyNameParts[0], $this->metadata->embeddedClasses);
     }
 
-    public function getPropertyMetadata(string $propertyName): array
-    {
-        trigger_deprecation('symfony/ux-autocomplete', '2.15.0', 'Calling EntityMetadata::getPropertyMetadata() is deprecated. You should stop using it, as it will be removed in the future.');
-
-        try {
-            return $this->getFieldMetadata($propertyName);
-        } catch (\InvalidArgumentException $e) {
-            return $this->getAssociationMetadata($propertyName);
-        }
-    }
-
     /**
      * @internal
      *

src/Autocomplete/src/Form/AutocompleteEntityTypeSubscriber.php

@@ -19,7 +19,6 @@
 use Symfony\Component\OptionsResolver\Options;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
-use Symfony\UX\Autocomplete\Form\ChoiceList\Loader\ExtraLazyChoiceLoader;
 
 /**
  * All form types that want to expose autocomplete functionality should use this for its getParent().
@@ -43,11 +42,11 @@ public function configureOptions(OptionsResolver $resolver): void
                 return null;
             }
 
-            if (class_exists(LazyChoiceLoader::class)) {
-                return new LazyChoiceLoader($loader);
+            if (!class_exists(LazyChoiceLoader::class)) {
+                throw new \LogicException(\sprintf('Using "%s" with "%s" requires symfony/form >= 7.2 to be installed. Try running "composer require symfony/form:>=7.2".', LazyChoiceLoader::class, __CLASS__));
             }
 
-            return new ExtraLazyChoiceLoader($loader);
+            return new LazyChoiceLoader($loader);
         };
 
         $resolver->setDefaults([