Commit 1db34a8
committed
feature #1224 Add "type: module" for all packages and changing main -> module (weaverryan)
This PR was merged into the 2.x branch.
Discussion
----------
Add "type: module" for all packages and changing main -> module
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| Tickets | None
| License | MIT
Follow up on https://github.com/symfony/ux/pull/1202/files#r1367791334
We already use ESM inside of our packages. This makes that official with `type: module`. Some notes / questions:
A) I believe, since we already ONLY made "modules" available, that this will have no effect on end users, but I'm not 100% sure about that. If someone is using `require` instead of `import`, it would affect them... but in that case, I believe `require` would not have worked before anyway. But if anyone knows better than I do, I'd appreciate your notes.
B) Because we are a `type: module`, my impression is that `main` will not be used. And we can instead rely on `module`.
tl;dr I believe these changes won't have user-facing effects, but I'm not 100% sure about that... though I'm pretty sure that if they DO have user-facing effects, it would be limited to people who are currently using `require` with these packages.
Cheers!
Commits
-------
592be5e Specifically adding type: module for all packages and changing main -> moduleFile tree
16 files changed
+31
-16
lines changed- src
- Autocomplete/assets
- Chartjs/assets
- Cropperjs/assets
- Dropzone/assets
- LazyImage/assets
- LiveComponent/assets
- Notify/assets
- React/assets
- StimulusBundle/assets
- Svelte/assets
- Swup/assets
- TogglePassword/assets
- Translator/assets
- Turbo/assets
- Typed/assets
- Vue/assets
16 files changed
+31
-16
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
| 7 | + | |
6 | 8 | | |
7 | 9 | | |
8 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
| |||
0 commit comments