[Icons] add xmnls attribute to svg icons

Author: Enz000

src/Icons/CHANGELOG.md

@@ -4,6 +4,7 @@
 
 -   Add `aliases` configuration option to define icon alternative names.
 -   Add support for `int` and `float` attribute values in `<twig:ux:icon />`.
+-   Add `xmlns` attribute in downloaded svg.
 
 ## 2.19.0
 

src/Icons/src/Iconify.php

@@ -26,7 +26,8 @@
 final class Iconify
 {
     public const API_ENDPOINT = 'https://api.iconify.design';
-
+    public const XMLNS_URL = 'http://www.w3.org/2000/svg';
+    
     // URL must be 500 chars max (iconify limit)
     // -39 chars: https://api.iconify.design/XXX.json?icons=
     // -safe margin
@@ -90,6 +91,7 @@ public function fetchIcon(string $prefix, string $name): Icon
 
         return new Icon($data['icons'][$name]['body'], [
             'viewBox' => \sprintf('0 0 %s %s', $width ?? $height, $height ?? $width),
+            'xmlns' => self::XMLNS_URL,
         ]);
     }
 
@@ -137,6 +139,7 @@ public function fetchIcons(string $prefix, array $names): array
 
             $icons[$iconName] = new Icon($iconData['body'], [
                 'viewBox' => \sprintf('0 0 %d %d', $width ?? $height, $height ?? $width),
+                'xmlns' => self::XMLNS_URL,
             ]);
         }
 

src/Icons/tests/Unit/IconifyTest.php

@@ -47,7 +47,7 @@ public function testFetchIcon(): void
         $icon = $iconify->fetchIcon('bi', 'heart');
 
         $this->assertEquals($icon->getInnerSvg(), '<path d="M0 0h24v24H0z" fill="none"/>');
-        $this->assertEquals($icon->getAttributes(), ['viewBox' => '0 0 24 24']);
+        $this->assertEquals($icon->getAttributes(), ['viewBox' => '0 0 24 24', 'xmlns' => Iconify::XMLNS_URL]);
     }
 
     public function testFetchIconByAlias(): void
@@ -78,7 +78,7 @@ public function testFetchIconByAlias(): void
         $icon = $iconify->fetchIcon('bi', 'foo');
 
         $this->assertEquals($icon->getInnerSvg(), '<path d="M0 0h24v24H0z" fill="none"/>');
-        $this->assertEquals($icon->getAttributes(), ['viewBox' => '0 0 24 24']);
+        $this->assertEquals($icon->getAttributes(), ['viewBox' => '0 0 24 24', 'xmlns' => Iconify::XMLNS_URL]);
     }
 
     public function testFetchIconThrowsWhenIconSetDoesNotExists(): void