Skip to content

Commit 24becab

Browse files
committed
feature #3071 [Toolkit] Add npm & importmap package dependencies (Kocal)
This PR was merged into the 2.x branch. Discussion ---------- [Toolkit] Add npm & importmap package dependencies | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> I needed to reference a npm dependency while writing on new recipes for the Shadcn kit: <img width="1105" height="606" alt="Capture d’écran 2025-09-09 à 22 00 36" src="https://github.com/user-attachments/assets/0eddc386-cc01-4e0c-a32d-49b205034044" /> --- This pull request standardizes the way dependencies are defined across multiple `manifest.json` files for shadcn UI kits and updates the schema to support more flexible dependency definitions. It also introduces validation for NPM package names in the codebase. **Manifest and Schema Standardization:** * Updated all shadcn kit `manifest.json` files to use a `name` and optional `version` field for PHP dependencies instead of a single `package` field. This change improves consistency and clarity in dependency definitions. [[1]](diffhunk://#diff-24cc9d048e1ea32ab7acf1fb7b8efc19f740892833fa58111f4ebd5681fb85a0L12-R21) [[2]](diffhunk://#diff-b88f95cca40ccb21517ed364d1ae64aeb88625bda8ee3da66111c2977bb52803L12-R12) [[3]](diffhunk://#diff-22812152398ca59e604a70fa497e5dd421c73d4f857cf9606f3d027629b1e646L12-R12) [[4]](diffhunk://#diff-23649306253ca91b727e2ba788da884362b816613e06e421c63ed6ff3e9376e7L12-R21) [[5]](diffhunk://#diff-ff8180c4acd43b8012cf5790f0319ea396f585cd44c2a0f9a12ce7a48b2e26ecL12-R21) [[6]](diffhunk://#diff-58e4e9e27cd161c6c739e6266b1d8ed70d392dcb94735fe8ada7ef1bfb3cf153L12-R12) [[7]](diffhunk://#diff-eebe4e88402ef66554bcf3cf7f4493f792cb0b256260244f45c06f4f66324676L12-R12) [[8]](diffhunk://#diff-dc966598cc48b9fafca139520d6c4c8bcb01e15f9dcd1b21eeab3e44480f6953L12-R12) [[9]](diffhunk://#diff-b28127a845fc2217410a6f1102e2f3b16e2e9fb7b28feadf2900bcd006f8186bL12-R12) [[10]](diffhunk://#diff-f400467d5964388d2cbffbd607263fb117cefb551274af8d88fb6e7633458570L12-R12) [[11]](diffhunk://#diff-ab4aa0c78bcfd808215b9af335558a2722e7041b5be90e8c727ea1608382dbe2L12-R12) [[12]](diffhunk://#diff-8374d2d2da8dd79902987f5913ec25d1589e32ba375c1190b14636075bae911fL12-R12) [[13]](diffhunk://#diff-93608b7d5d7d64f6828df2efea3c92051aba82d16d5f9dcd56e77a51200918c7L12-R12) [[14]](diffhunk://#diff-a69e9e15bbfdafddae62b804ce99f760a6d10eef61089edd8b2f0acab801e8f5L12-R21) [[15]](diffhunk://#diff-40e38b9daaeb10efbd842b74917b8f40ad64e912e575608ac226a4851fb37a33L12-R12) [[16]](diffhunk://#diff-8b5e2a122852d850f2fb8e600e44359b85463e3e1b846a56c09c61b3dfaa27f6L12-R12) [[17]](diffhunk://#diff-594246d37d7eb85f199937add11bc90acb9afaa22ba2024ed890fab8dc826e49L12-R12) [[18]](diffhunk://#diff-e4302dc4e8a19f84ad686273ec8ba2d13bbf9861a92dbfa79d92b7f46c8d712bL12-R12) * Enhanced the `schema-kit-recipe-v1.json` schema to: - Require `name` instead of `package` for PHP dependencies. - Add support for NPM and Importmap dependencies, each with their own required fields and validation. **Validation Improvements:** * Added a new `Assert::npmPackageName` method to validate NPM package names, ensuring only valid names are accepted when defining NPM dependencies. Commits ------- f783a4f [Toolkit] Add npm & importmap package dependencies
2 parents eeb13e1 + f783a4f commit 24becab

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+744
-73
lines changed

src/Toolkit/kits/shadcn/Alert/manifest.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,16 @@
99
"dependencies": [
1010
{
1111
"type": "php",
12-
"package": "twig/extra-bundle"
12+
"name": "twig/extra-bundle"
1313
},
1414
{
1515
"type": "php",
16-
"package": "twig/html-extra:^3.12.0"
16+
"name": "twig/html-extra",
17+
"version": "^3.12.0"
1718
},
1819
{
1920
"type": "php",
20-
"package": "tales-from-a-dev/twig-tailwind-extra"
21+
"name": "tales-from-a-dev/twig-tailwind-extra"
2122
}
2223
]
2324
}

src/Toolkit/kits/shadcn/AspectRatio/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"dependencies": [
1010
{
1111
"type": "php",
12-
"package": "twig/extra-bundle"
12+
"name": "twig/extra-bundle"
1313
}
1414
]
1515
}

src/Toolkit/kits/shadcn/Avatar/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"dependencies": [
1010
{
1111
"type": "php",
12-
"package": "tales-from-a-dev/twig-tailwind-extra"
12+
"name": "tales-from-a-dev/twig-tailwind-extra"
1313
}
1414
]
1515
}

src/Toolkit/kits/shadcn/Badge/manifest.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,16 @@
99
"dependencies": [
1010
{
1111
"type": "php",
12-
"package": "twig/extra-bundle"
12+
"name": "twig/extra-bundle"
1313
},
1414
{
1515
"type": "php",
16-
"package": "twig/html-extra:^3.12.0"
16+
"name": "twig/html-extra",
17+
"version": "^3.12.0"
1718
},
1819
{
1920
"type": "php",
20-
"package": "tales-from-a-dev/twig-tailwind-extra"
21+
"name": "tales-from-a-dev/twig-tailwind-extra"
2122
}
2223
]
2324
}

src/Toolkit/kits/shadcn/Breadcrumb/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"dependencies": [
1010
{
1111
"type": "php",
12-
"package": "tales-from-a-dev/twig-tailwind-extra"
12+
"name": "tales-from-a-dev/twig-tailwind-extra"
1313
}
1414
]
1515
}

src/Toolkit/kits/shadcn/Button/manifest.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,16 @@
99
"dependencies": [
1010
{
1111
"type": "php",
12-
"package": "twig/extra-bundle"
12+
"name": "twig/extra-bundle"
1313
},
1414
{
1515
"type": "php",
16-
"package": "twig/html-extra:^3.12.0"
16+
"name": "twig/html-extra",
17+
"version": "^3.12.0"
1718
},
1819
{
1920
"type": "php",
20-
"package": "tales-from-a-dev/twig-tailwind-extra"
21+
"name": "tales-from-a-dev/twig-tailwind-extra"
2122
}
2223
]
2324
}

src/Toolkit/kits/shadcn/Card/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"dependencies": [
1010
{
1111
"type": "php",
12-
"package": "tales-from-a-dev/twig-tailwind-extra"
12+
"name": "tales-from-a-dev/twig-tailwind-extra"
1313
}
1414
]
1515
}

src/Toolkit/kits/shadcn/Checkbox/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"dependencies": [
1010
{
1111
"type": "php",
12-
"package": "tales-from-a-dev/twig-tailwind-extra"
12+
"name": "tales-from-a-dev/twig-tailwind-extra"
1313
}
1414
]
1515
}

src/Toolkit/kits/shadcn/Input/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"dependencies": [
1010
{
1111
"type": "php",
12-
"package": "tales-from-a-dev/twig-tailwind-extra"
12+
"name": "tales-from-a-dev/twig-tailwind-extra"
1313
}
1414
]
1515
}

src/Toolkit/kits/shadcn/Label/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"dependencies": [
1010
{
1111
"type": "php",
12-
"package": "tales-from-a-dev/twig-tailwind-extra"
12+
"name": "tales-from-a-dev/twig-tailwind-extra"
1313
}
1414
]
1515
}

0 commit comments

Comments
 (0)