Skip to content

Commit 251d673

Browse files
pink6440smnandre
andauthored
Apply suggestions from code review
Thanks for the review ! Co-authored-by: Simon André <[email protected]>
1 parent 1eebe17 commit 251d673

File tree

3 files changed

+0
-5
lines changed

3 files changed

+0
-5
lines changed

src/LiveComponent/src/Hydration/DoctrineEntityHydrationExtension.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,6 @@ public function dehydrate(object $object): mixed
8282
private function objectManagerFor(string $class): ?ObjectManager
8383
{
8484
if (class_exists($class)) {
85-
// Keep the standard way for a class
86-
// todo cache/warmup an array of classes that are "doctrine objects"
8785
foreach ($this->managerRegistries as $registry) {
8886
if ($om = $registry->getManagerForClass($class)) {
8987
return self::ensureManagedObject($om, $class);
@@ -102,7 +100,6 @@ private function objectManagerFor(string $class): ?ObjectManager
102100
// Fore more details :
103101
// @see \Doctrine\ORM\Tools\ResolveTargetEntityListener
104102

105-
// todo cache/warmup an array of interfaces that are resolved "doctrine objects"
106103
foreach ($this->managerRegistries as $registry) {
107104
foreach ($registry->getManagers() as $om) {
108105
// the getClassMetaData can indeed throw an exception

src/LiveComponent/tests/Fixtures/Dto/Aliased.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,5 @@
44

55
class Aliased
66
{
7-
// public string $address;
87
public string $name;
98
}

src/LiveComponent/tests/Fixtures/Entity/AliasedEntityInterface.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,4 @@
33
namespace Symfony\UX\LiveComponent\Tests\Fixtures\Entity;
44

55
interface AliasedEntityInterface {
6-
76
}

0 commit comments

Comments
 (0)