Skip to content

Commit 38998c1

Browse files
committed
minor #1804 [Site] Various small fixes / improvements (smnandre)
This PR was squashed before being merged into the 2.x branch. Discussion ---------- [Site] Various small fixes / improvements A lot of small things grouped in a medium-sized PR 👼 - Lint templates - Normalize template names - Fix some spacings - Fix CodeBlock expander - SVG image for header logo - Improve CodeBlocWithComment readability - Rework code block expand button - Fix terminal style - Add missing doc cards in "footer" - Remove unused image - Compress 2 photos & win 8MB - Clean clipboard controller(s) - Fix header padding - Fix Icon cards on Safari - Simplify Turbo chat icon - Remove Playfair Commits ------- e0bda68 [Site] Various small fixes / improvements
2 parents db88684 + e0bda68 commit 38998c1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

62 files changed

+197
-172
lines changed

ux.symfony.com/assets/controllers/code-expander-controller.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,6 @@ import { Controller } from '@hotwired/stimulus';
44
export default class extends Controller {
55
static targets = ['useStatements', 'expandCodeButton', 'codeContent'];
66

7-
connect() {
8-
if (this.hasExpandCodeButtonTarget && this.#isOverflowing(this.codeContentTarget)) {
9-
this.expandCodeButtonTarget.style.display = 'block';
10-
// add extra padding so the button doesn't block the code
11-
this.codeContentTarget.classList.add('pb-5');
12-
}
13-
}
14-
157
expandUseStatements(event) {
168
this.useStatementsTarget.style.display = 'block';
179
event.currentTarget.remove();
@@ -21,7 +13,6 @@ export default class extends Controller {
2113
this.codeContentTarget.style.height = 'auto';
2214
if (this.hasExpandCodeButtonTarget) {
2315
this.expandCodeButtonTarget.remove();
24-
this.codeContentTarget.classList.remove('pb-5');
2516
}
2617
}
2718

ux.symfony.com/assets/controllers/ux-clipboard-controller.js

Lines changed: 0 additions & 21 deletions
This file was deleted.
-6.42 MB
Loading
-2.03 MB
Loading
-79.6 KB
Binary file not shown.

ux.symfony.com/assets/styles/app.scss

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -110,19 +110,7 @@
110110
@import "./container";
111111
@import "./images";
112112

113-
// TODO move Terminal/CodeBlock
114-
.btn-expand-code {
115-
position: absolute;
116-
bottom: 0;
117-
left: 0;
118-
width: 100%;
119-
color: rgb(156 163 175);
120-
background-color: rgb(9, 10, 11);
121-
}
122-
.btn-expand-code:hover, .btn-expand-code:active {
123-
background-color: rgb(9, 10, 11) !important;
124-
color: #fff !important;
125-
}
126113
.code-description a {
127114
text-decoration: underline;
128115
}
116+

ux.symfony.com/assets/styles/app/_font.scss

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,3 @@
2020
url("https://cdn.jsdelivr.net/npm/@fontsource/[email protected]/files/ubuntu-latin-700-normal.woff2") format('woff2');
2121
unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+0304, U+0308, U+0329, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
2222
}
23-
24-
/* playfair-display-latin-700-italic */
25-
@font-face {
26-
font-family: 'Playfair Display';
27-
font-style: italic;
28-
font-display: swap;
29-
font-weight: 700;
30-
src: local("Playfair Display Bold Italic"),
31-
local("PlayfairDisplay-Bold-Italic"),
32-
url("https://cdn.jsdelivr.net/npm/@fontsource/[email protected]/files/playfair-display-latin-700-italic.woff2") format('woff2');
33-
}

ux.symfony.com/assets/styles/app/_html.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,9 @@ button {
4141
border: none;
4242
background: inherit;
4343
}
44+
button:active {
45+
border: inherit;
46+
}
4447

4548
a.link {
4649
--color: #d9438e;

ux.symfony.com/assets/styles/app/_root.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
// Fonts
1717
--font-family-title: "Ubuntu";
18-
--font-family-decorative: "Playfair Display";
1918
--font-family-text: system-ui, sans-serif;
2019
--font-family-code: ui-monospace, "SF Mono", SFMono-Regular, 'Cascadia Code', 'Source Code Pro', Menlo, Consolas, 'DejaVu Sans Mono', monospace;
2120

ux.symfony.com/assets/styles/app/_typography.scss

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,6 @@ h1.ubuntu {
99
line-height: 60px;
1010
}
1111

12-
h1 .playfair {
13-
font-style: italic;
14-
line-height: 70px;
15-
}
16-
1712
h2.ubuntu {
1813
font-size: 42px;
1914
font-weight: 700;
@@ -88,12 +83,6 @@ h4.ubuntu {
8883
letter-spacing: -1px;
8984
}
9085

91-
h1.playfair {
92-
font-size: 36px;
93-
line-height: 48px;
94-
letter-spacing: -1px;
95-
}
96-
9786
h2.ubuntu {
9887
font-size: 28px;
9988
line-height: 32px;

0 commit comments

Comments
 (0)