[Twig] Store mount methods in compiler pass

Author: smnandre

src/TwigComponent/src/ComponentFactory.php

@@ -15,7 +15,6 @@
 use Symfony\Component\DependencyInjection\ServiceLocator;
 use Symfony\Component\PropertyAccess\PropertyAccessorInterface;
 use Symfony\Contracts\Service\ResetInterface;
-use Symfony\UX\TwigComponent\Attribute\AsTwigComponent;
 use Symfony\UX\TwigComponent\Event\PostMountEvent;
 use Symfony\UX\TwigComponent\Event\PreMountEvent;
 
@@ -27,8 +26,6 @@
 final class ComponentFactory implements ResetInterface
 {
     private static $mountMethods = [];
-    private static $preMountMethods = [];
-    private static $postMountMethods = [];
 
     /**
      * @param array<string, array>        $config
@@ -151,23 +148,15 @@ private function mount(object $component, array &$data): void
 
             return;
         }
-
-        if (null === (self::$mountMethods[$component::class] ?? null)) {
-            try {
-                $mountMethod = self::$mountMethods[$component::class] = (new \ReflectionClass($component))->getMethod('mount');
-            } catch (\ReflectionException) {
-                self::$mountMethods[$component::class] = false;
-
-                return;
-            }
-        }
-
-        if (false === $mountMethod ??= self::$mountMethods[$component::class]) {
+        
+        if (!($this->config[$component::class]['mount'] ?? false)) {
             return;
         }
-
+        
+        $mount = self::$mountMethods[$component::class] ??= (new \ReflectionClass($component))->getMethod('mount');
+        
         $parameters = [];
-        foreach ($mountMethod->getParameters() as $refParameter) {
+        foreach ($mount->getParameters() as $refParameter) {
             if (\array_key_exists($name = $refParameter->getName(), $data)) {
                 $parameters[] = $data[$name];
                 // remove the data element so it isn't used to set the property directly.
@@ -179,7 +168,7 @@ private function mount(object $component, array &$data): void
             }
         }
 
-        $mountMethod->invoke($component, ...$parameters);
+        $mount->invoke($component, ...$parameters);
     }
 
     private function preMount(object $component, array $data, ComponentMetadata $componentMetadata): array
@@ -188,10 +177,11 @@ private function preMount(object $component, array $data, ComponentMetadata $com
         $this->eventDispatcher->dispatch($event);
         $data = $event->getData();
 
-        $methods = self::$preMountMethods[$component::class] ??= AsTwigComponent::preMountMethods($component::class);
-        foreach ($methods as $method) {
-            if (null !== $newData = $method->invoke($component, $data)) {
-                $data = $newData;
+        if ($preMounts = $this->config[$component::class]['preMount'] ?? []) {
+            foreach ($preMounts as $preMount) {
+                if (null !== $newData = $component->$preMount($data)) {
+                    $data = $newData;
+                }
             }
         }
 
@@ -207,10 +197,11 @@ private function postMount(object $component, array $data, ComponentMetadata $co
         $this->eventDispatcher->dispatch($event);
         $data = $event->getData();
 
-        $methods = self::$postMountMethods[$component::class] ??= AsTwigComponent::postMountMethods($component::class);
-        foreach ($methods as $method) {
-            if (null !== $newData = $method->invoke($component, $data)) {
-                $data = $newData;
+        if ($postMounts = $this->config[$component::class]['postMount'] ?? []) {
+            foreach ($postMounts as $postMount) {
+                if (null !== $newData = $component->$postMount($data)) {
+                    $data = $newData;
+                }
             }
         }
 
@@ -257,7 +248,5 @@ private function throwUnknownComponentException(string $name): void
     public function reset(): void
     {
         self::$mountMethods = [];
-        self::$preMountMethods = [];
-        self::$postMountMethods = [];
     }
 }

src/TwigComponent/src/DependencyInjection/Compiler/TwigComponentPass.php

@@ -16,6 +16,8 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Exception\LogicException;
 use Symfony\Component\DependencyInjection\Reference;
+use Symfony\UX\TwigComponent\Attribute\PostMount;
+use Symfony\UX\TwigComponent\Attribute\PreMount;
 
 /**
  * @author Kevin Bond <[email protected]>
@@ -68,7 +70,7 @@ public function process(ContainerBuilder $container): void
                 $tag['service_id'] = $id;
                 $tag['class'] = $definition->getClass();
                 $tag['template'] = $tag['template'] ?? $this->calculateTemplate($tag['key'], $defaults);
-                $componentConfig[$tag['key']] = $tag;
+                $componentConfig[$tag['key']] = [...$tag, ...$this->getMountMethods($tag['class'])];
                 $componentReferences[$tag['key']] = new Reference($id);
                 $componentNames[] = $tag['key'];
                 $componentClassMap[$tag['class']] = $tag['key'];
@@ -109,4 +111,46 @@ private function calculateTemplate(string $componentName, ?array $defaults): str
 
         return \sprintf('%s/%s.html.twig', rtrim($directory, '/'), str_replace(':', '/', $componentName));
     }
+    
+    /**
+     * @param class-string $component
+     * @return array{preMount: string[], mount: string[], postMount: string[]}
+     */
+    private function getMountMethods(string $component): array
+    {
+        $preMount = [];
+        $mount = [];
+        $postMount = [];
+        
+        foreach ((new \ReflectionClass($component))->getMethods(\ReflectionMethod::IS_PUBLIC) as $method) {
+            foreach ($method->getAttributes(PreMount::class) as $attribute) {
+                $preMount[$method->getName()] = $attribute->newInstance()->priority;
+            }
+            foreach ($method->getAttributes(PostMount::class) as $attribute) {
+                $postMount[$method->getName()] = $attribute->newInstance()->priority;
+            }
+            if ('mount' === $method->getName()) {
+                $mount['mount'] = 0;
+            }
+        }
+        
+        if ($preMount) {
+            arsort($preMount);
+            $preMount = array_keys($preMount);
+        }
+        if ($mount) {
+            arsort($mount);
+            $mount = array_keys($mount);
+        }
+        if ($postMount) {
+            arsort($postMount);
+            $postMount = array_keys($postMount);
+        }
+        
+        return [
+            'preMount' => $preMount,
+            'mount' => $mount,
+            'postMount' => $postMount,
+        ];
+    }
 }