Skip to content

Commit 61b90a4

Browse files
committed
minor #2852 [CI] Reduce number of PHPStan jobs (Kocal)
This PR was merged into the 2.x branch. Discussion ---------- [CI] Reduce number of PHPStan jobs | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> After some reflexions, I don't think there is a need to run PHPStan over all supported PHP versions, only the lowest one we support (8.1) and highest one (8.4) is enough. Playing with dependency versions, stability, and Symfony versions still make sense Commits ------- 606d7f7 [CI] Reduce number of PHPStan jobs
2 parents 5cb3f1c + 606d7f7 commit 61b90a4

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

.github/workflows/code-quality.yaml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,17 +46,18 @@ jobs:
4646
strategy:
4747
fail-fast: false
4848
matrix:
49-
php-version: [ '8.1', '8.2', '8.3', '8.4']
49+
php-version: ['8.1']
5050
dependency-version: ['']
5151
symfony-version: ['']
5252
minimum-stability: ['stable']
5353
include:
54+
# dev packages (probably not needed to have multiple such jobs)
55+
- minimum-stability: 'dev'
56+
php-version: 8.4
5457
# lowest deps
55-
- php-version: '8.1'
56-
dependency-version: 'lowest'
58+
- dependency-version: 'lowest'
5759
# LTS version of Symfony
58-
- php-version: '8.1'
59-
symfony-version: '6.4.*'
60+
- symfony-version: '6.4.*'
6061
steps:
6162
- name: Checkout
6263
uses: actions/checkout@v4
@@ -78,7 +79,7 @@ jobs:
7879
- name: Setup PHP
7980
uses: shivammathur/setup-php@v2
8081
with:
81-
php-version: ${{ matrix.php-version }}
82+
php-version: 8.1
8283
tools: flex
8384

8485
- name: Install root dependencies

0 commit comments

Comments
 (0)