Skip to content

Commit 63846e7

Browse files
smnandreKocal
authored andcommitted
Remove StimulusHelper deprecation
1 parent ea00519 commit 63846e7

File tree

4 files changed

+4
-52
lines changed

4 files changed

+4
-52
lines changed

src/Chartjs/src/Twig/ChartExtension.php

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
use Symfony\UX\Chartjs\Model\Chart;
1515
use Symfony\UX\StimulusBundle\Helper\StimulusHelper;
16-
use Symfony\WebpackEncoreBundle\Twig\StimulusTwigExtension;
1716
use Twig\Extension\AbstractExtension;
1817
use Twig\TwigFunction;
1918

@@ -24,19 +23,8 @@
2423
*/
2524
class ChartExtension extends AbstractExtension
2625
{
27-
private $stimulus;
28-
29-
/**
30-
* @param $stimulus StimulusHelper
31-
*/
32-
public function __construct(StimulusHelper|StimulusTwigExtension $stimulus)
26+
public function __construct(private StimulusHelper $stimulusHelper)
3327
{
34-
if ($stimulus instanceof StimulusTwigExtension) {
35-
trigger_deprecation('symfony/ux-chartjs', '2.9', 'Passing an instance of "%s" to "%s" is deprecated, pass an instance of "%s" instead.', StimulusTwigExtension::class, __CLASS__, StimulusHelper::class);
36-
$stimulus = new StimulusHelper(null);
37-
}
38-
39-
$this->stimulus = $stimulus;
4028
}
4129

4230
public function getFunctions(): array

src/Notify/src/Twig/NotifyRuntime.php

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,29 +13,17 @@
1313

1414
use Symfony\Component\Mercure\HubInterface;
1515
use Symfony\UX\StimulusBundle\Helper\StimulusHelper;
16-
use Symfony\WebpackEncoreBundle\Twig\StimulusTwigExtension;
1716
use Twig\Extension\RuntimeExtensionInterface;
1817

1918
/**
2019
* @author Mathias Arlaud <[email protected]>
2120
*/
2221
final class NotifyRuntime implements RuntimeExtensionInterface
2322
{
24-
private StimulusHelper $stimulusHelper;
25-
26-
/**
27-
* @param $stimulus StimulusHelper
28-
*/
2923
public function __construct(
3024
private HubInterface $hub,
31-
StimulusHelper|StimulusTwigExtension $stimulus,
25+
private StimulusHelper $stimulusHelper,
3226
) {
33-
if ($stimulus instanceof StimulusTwigExtension) {
34-
trigger_deprecation('symfony/ux-notify', '2.9', 'Passing an instance of "%s" to "%s" is deprecated, pass an instance of "%s" instead.', StimulusTwigExtension::class, __CLASS__, StimulusHelper::class);
35-
$stimulus = new StimulusHelper(null);
36-
}
37-
38-
$this->stimulusHelper = $stimulus;
3927
}
4028

4129
public function renderStreamNotifications(array|string $topics = [], array $options = []): string

src/React/src/Twig/ReactComponentExtension.php

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
namespace Symfony\UX\React\Twig;
1313

1414
use Symfony\UX\StimulusBundle\Helper\StimulusHelper;
15-
use Symfony\WebpackEncoreBundle\Twig\StimulusTwigExtension;
1615
use Twig\Extension\AbstractExtension;
1716
use Twig\TwigFunction;
1817

@@ -23,19 +22,8 @@
2322
*/
2423
class ReactComponentExtension extends AbstractExtension
2524
{
26-
private $stimulusHelper;
27-
28-
/**
29-
* @param $stimulus StimulusHelper
30-
*/
31-
public function __construct(StimulusHelper|StimulusTwigExtension $stimulus)
25+
public function __construct(private StimulusHelper $stimulusHelper)
3226
{
33-
if ($stimulus instanceof StimulusTwigExtension) {
34-
trigger_deprecation('symfony/ux-react', '2.9', 'Passing an instance of "%s" to "%s" is deprecated, pass an instance of "%s" instead.', StimulusTwigExtension::class, __CLASS__, StimulusHelper::class);
35-
$stimulus = new StimulusHelper(null);
36-
}
37-
38-
$this->stimulusHelper = $stimulus;
3927
}
4028

4129
public function getFunctions(): array

src/Svelte/src/Twig/SvelteComponentExtension.php

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
namespace Symfony\UX\Svelte\Twig;
1313

1414
use Symfony\UX\StimulusBundle\Helper\StimulusHelper;
15-
use Symfony\WebpackEncoreBundle\Twig\StimulusTwigExtension;
1615
use Twig\Extension\AbstractExtension;
1716
use Twig\TwigFunction;
1817

@@ -24,19 +23,8 @@
2423
*/
2524
class SvelteComponentExtension extends AbstractExtension
2625
{
27-
private $stimulusHelper;
28-
29-
/**
30-
* @param $stimulus StimulusHelper
31-
*/
32-
public function __construct(StimulusHelper|StimulusTwigExtension $stimulus)
26+
public function __construct(private StimulusHelper $stimulusHelper)
3327
{
34-
if ($stimulus instanceof StimulusTwigExtension) {
35-
trigger_deprecation('symfony/ux-svelte', '2.9', 'Passing an instance of "%s" to "%s" is deprecated, pass an instance of "%s" instead.', StimulusTwigExtension::class, __CLASS__, StimulusHelper::class);
36-
$stimulus = new StimulusHelper(null);
37-
}
38-
39-
$this->stimulusHelper = $stimulus;
4028
}
4129

4230
public function getFunctions(): array

0 commit comments

Comments
 (0)