You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
minor #1810 [TwigComponent]: Fix silently failing tests (alucas-campings)
This PR was merged into the 2.x branch.
Discussion
----------
[TwigComponent]: Fix silently failing tests
| Q | A
| ------------- | ---
| Bug fix? no
| New feature? no
| Issues | Fix silently failing tests
| License | MIT
This tries to fix two little mistakes :
- the `expectException` should never be used twice in a test (because it does not actually try/catch, the first exception will stop the execution of the test and will be catched outside).
- the piece of code that is expected to throw an exception should always come last in the test (because again, no try/catch, so any line after the throwing line will not be executed).
Commits
-------
d397e1e [TwigComponent]: Fix silently failing tests
0 commit comments