feature #1249 [LiveComponent] Normalize "true" & "false" model values (smnandre)

This PR was merged into the 2.x branch.

Discussion
----------

[LiveComponent] Normalize "true" & "false" model values

| Q             | A
| ------------- | ---
| Bug fix?      | yes?
| New feature?  | no?
| Issues        | Fix #1211
| License       | MIT

Coerce strings "true" & "false" to their boolean equivalent (same for 0 and 1)

```php
  private static function coerceStringToBoolean(string $value): bool
    {
        $booleanMap = [
            '0' => false,
            '1' => true,
            'false' => false,
            'true' => true,
        ];

        return $booleanMap[$value] ?? (bool) $value;
    }
```

Is that what you had in mind `@weaverryan` ?

Commits
-------

7fbac61 [LiveComponent] Normalize "true" & "false" model values

Author: weaverryan

src/LiveComponent/src/LiveComponentHydrator.php

@@ -244,11 +244,23 @@ private static function coerceStringValue(string $value, string $type, bool $all
         return match ($type) {
             'int' => (int) $value,
             'float' => (float) $value,
-            'bool' => (bool) $value,
+            'bool' => self::coerceStringToBoolean($value),
             default => throw new \LogicException(sprintf('Cannot coerce value "%s" to type "%s"', $value, $type)),
         };
     }
 
+    private static function coerceStringToBoolean(string $value): bool
+    {
+        $booleanMap = [
+            '0' => false,
+            '1' => true,
+            'false' => false,
+            'true' => true,
+        ];
+
+        return $booleanMap[$value] ?? (bool) $value;
+    }
+
     private function calculateChecksum(array $dehydratedPropsData): ?string
     {
         // sort so it is always consistent (frontend could have re-ordered data)

src/LiveComponent/tests/Integration/LiveComponentHydratorTest.php

@@ -1460,6 +1460,20 @@ public function testCanDehydrateAndHydrateComponentsWithEmptyAttributes(): void
         $this->assertSame([], $actualAttributes->all());
     }
 
+    /**
+     * @dataProvider truthyValueProvider
+     */
+    public function testCoerceTruthyValuesForScalarTypes($prop, $value, $expected): void
+    {
+        $dehydratedProps = $this->dehydrateComponent($this->mountComponent('scalar_types'))->getProps();
+
+        $updatedProps = [$prop => $value];
+        $hydratedComponent = $this->getComponent('scalar_types');
+        $this->hydrateComponent($hydratedComponent, 'scalar_types', $dehydratedProps, $updatedProps);
+
+        $this->assertSame($expected, $hydratedComponent->$prop);
+    }
+
     /**
      * @dataProvider falseyValueProvider
      */
@@ -1474,6 +1488,15 @@ public function testCoerceFalseyValuesForScalarTypes($prop, $value, $expected):
         $this->assertSame($expected, $hydratedComponent->$prop);
     }
 
+    public static function truthyValueProvider(): iterable
+    {
+        yield ['int', '1', 1];
+        yield ['float', '1', 1.0];
+        yield ['float', 'true', 0.0];
+        yield ['bool', 'true', true];
+        yield ['bool', '1', true];
+    }
+
     public static function falseyValueProvider(): iterable
     {
         yield ['int', '', 0];
@@ -1484,6 +1507,7 @@ public static function falseyValueProvider(): iterable
         yield ['float', 'apple', 0.0];
         yield ['bool', '', false];
         yield ['bool', '   ', false];
+        yield ['bool', 'false', false];
 
         yield ['nullableInt', '', null];
         yield ['nullableInt', '   ', null];