Skip to content

Commit 8c6b523

Browse files
ValmonzoKocal
authored andcommitted
fix post reviews
1 parent 9c85cc5 commit 8c6b523

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

src/Map/src/Bridge/Google/assets/dist/map_controller.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import AbstractMapController from '@symfony/ux-map';
33
import type { CircleDefinition, Icon, InfoWindowWithoutPositionDefinition, MarkerDefinition, Point, PolygonDefinition, PolylineDefinition, RectangleDefinition } from '@symfony/ux-map';
44
type MapOptions = Pick<google.maps.MapOptions, 'mapId' | 'gestureHandling' | 'backgroundColor' | 'disableDoubleClickZoom' | 'zoomControl' | 'zoomControlOptions' | 'mapTypeControl' | 'mapTypeControlOptions' | 'streetViewControl' | 'streetViewControlOptions' | 'fullscreenControl' | 'fullscreenControlOptions'>;
55
export default class extends AbstractMapController<MapOptions, google.maps.Map, google.maps.marker.AdvancedMarkerElementOptions, google.maps.marker.AdvancedMarkerElement, google.maps.InfoWindowOptions, google.maps.InfoWindow, google.maps.PolygonOptions, google.maps.Polygon, google.maps.PolylineOptions, google.maps.Polyline, google.maps.CircleOptions, google.maps.Circle, google.maps.RectangleOptions, google.maps.Rectangle> {
6-
protected doRemoveRectangle(rectangle: google.maps.Rectangle): void;
76
providerOptionsValue: Pick<LoaderOptions, 'apiKey' | 'id' | 'language' | 'region' | 'nonce' | 'retries' | 'url' | 'version' | 'libraries'>;
87
map: google.maps.Map;
98
parser: DOMParser;
@@ -35,6 +34,7 @@ export default class extends AbstractMapController<MapOptions, google.maps.Map,
3534
protected doCreateRectangle({ definition, }: {
3635
definition: RectangleDefinition<google.maps.RectangleOptions, google.maps.InfoWindowOptions>;
3736
}): google.maps.Rectangle;
37+
protected doRemoveRectangle(rectangle: google.maps.Rectangle): void;
3838
protected doCreateInfoWindow({ definition, element, }: {
3939
definition: InfoWindowWithoutPositionDefinition<google.maps.InfoWindowOptions>;
4040
element: google.maps.marker.AdvancedMarkerElement | google.maps.Polygon | google.maps.Polyline;

src/Map/src/Bridge/Google/assets/dist/map_controller.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,6 @@ let _loaded = false;
136136
let _onLoadedCallbacks = [];
137137
const parser = new DOMParser();
138138
class map_controller extends default_1 {
139-
doRemoveRectangle(rectangle) {
140-
throw new Error('Method not implemented.');
141-
}
142139
async connect() {
143140
const onLoaded = () => super.connect();
144141
if (_loaded) {
@@ -293,6 +290,9 @@ class map_controller extends default_1 {
293290
}
294291
return rectangle;
295292
}
293+
doRemoveRectangle(rectangle) {
294+
rectangle.setMap(null);
295+
}
296296
doCreateInfoWindow({ definition, element, }) {
297297
const { headerContent, content, extra, rawOptions = {}, ...otherOptions } = definition;
298298
const infoWindow = new _google.maps.InfoWindow({

src/Map/src/Bridge/Google/assets/src/map_controller.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,6 @@ export default class extends AbstractMapController<
6262
google.maps.RectangleOptions,
6363
google.maps.Rectangle
6464
> {
65-
protected doRemoveRectangle(rectangle: google.maps.Rectangle): void {
66-
throw new Error('Method not implemented.');
67-
}
6865
declare providerOptionsValue: Pick<
6966
LoaderOptions,
7067
'apiKey' | 'id' | 'language' | 'region' | 'nonce' | 'retries' | 'url' | 'version' | 'libraries'
@@ -304,6 +301,11 @@ export default class extends AbstractMapController<
304301

305302
return rectangle;
306303
}
304+
305+
protected doRemoveRectangle(rectangle: google.maps.Rectangle): void {
306+
rectangle.setMap(null);
307+
}
308+
307309
protected doCreateInfoWindow({
308310
definition,
309311
element,

0 commit comments

Comments
 (0)