Apply review suggestions and add an entry to the CHANGELOG file

Author: f-schnabel

src/Chartjs/CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.23.0
+
+-   Listen to Stimulus `disconnect` event to destroy the chart #1944
+
 ## 2.18.0
 
 -   Replace `chartjs/auto` import with explicit `Chart.register()` call #1263

src/Chartjs/assets/dist/controller.js

@@ -36,11 +36,11 @@ class default_1 extends Controller {
         this.dispatchEvent('connect', { chart: this.chart });
     }
     disconnect() {
+        this.dispatchEvent('disconnect', { chart: this.chart });
         if (this.chart) {
             this.chart.destroy();
             this.chart = null;
         }
-        this.dispatchEvent('disconnect', { chart: this.chart });
     }
     viewValueChanged() {
         if (this.chart) {

src/Chartjs/assets/src/controller.ts

@@ -58,12 +58,12 @@ export default class extends Controller {
     }
 
     disconnect() {
+        this.dispatchEvent('disconnect', { chart: this.chart });
+
         if (this.chart) {
             this.chart.destroy();
             this.chart = null;
         }
-
-        this.dispatchEvent('disconnect', { chart: this.chart });
     }
 
     /**