Skip to content

Commit 94f1391

Browse files
committed
[LiveComponent] Exclude unstable tests on Windows with @transient-on-windows
1 parent 49a85cc commit 94f1391

File tree

3 files changed

+17
-1
lines changed

3 files changed

+17
-1
lines changed

.github/workflows/unit-tests.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
echo COLUMNS=120 >> $GITHUB_ENV
6666
echo COMPOSER_MIN_STAB='composer config minimum-stability ${{ matrix.minimum-stability || 'stable' }} --ansi' >> $GITHUB_ENV
6767
echo COMPOSER_UP='composer update ${{ matrix.dependency-version == 'lowest' && '--prefer-lowest' || '' }} --no-progress --no-interaction --ansi' >> $GITHUB_ENV
68-
echo PHPUNIT='vendor/bin/simple-phpunit' >> $GITHUB_ENV
68+
echo PHPUNIT='vendor/bin/simple-phpunit ${{ matrix.os == 'windows-latest' && '--exclude-group transient-on-windows' || '' }}' >> $GITHUB_ENV
6969
[ 'lowest' = '${{ matrix.dependency-version }}' ] && export SYMFONY_DEPRECATIONS_HELPER=weak
7070
7171
# Swup and Typed have no tests, Turbo has its own workflow file

src/LiveComponent/tests/Functional/EventListener/LiveComponentSubscriberTest.php

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,9 @@ public function testCanRenderComponentAsHtmlWithAlternateRoute()
9191
;
9292
}
9393

94+
/**
95+
* @group transient-on-windows
96+
*/
9497
public function testCanExecuteComponentActionNormalRoute()
9598
{
9699
$templateName = 'render_embedded_with_blocks.html.twig';
@@ -189,6 +192,9 @@ public function testPreReRenderHookOnlyExecutedDuringAjax()
189192
;
190193
}
191194

195+
/**
196+
* @group transient-on-windows
197+
*/
192198
public function testItAddsEmbeddedTemplateContextToEmbeddedComponents()
193199
{
194200
$templateName = 'render_embedded_with_blocks.html.twig';
@@ -226,6 +232,9 @@ public function testItAddsEmbeddedTemplateContextToEmbeddedComponents()
226232
;
227233
}
228234

235+
/**
236+
* @group transient-on-windows
237+
*/
229238
public function testItWorksWithNamespacedTemplateNamesForEmbeddedComponents()
230239
{
231240
$templateName = 'render_embedded_with_blocks.html.twig';
@@ -239,6 +248,9 @@ public function testItWorksWithNamespacedTemplateNamesForEmbeddedComponents()
239248
;
240249
}
241250

251+
/**
252+
* @group transient-on-windows
253+
*/
242254
public function testItUseBlocksFromEmbeddedContextUsingMultipleComponents()
243255
{
244256
$templateName = 'render_multiple_embedded_with_blocks.html.twig';
@@ -271,6 +283,9 @@ public function testItUseBlocksFromEmbeddedContextUsingMultipleComponents()
271283
;
272284
}
273285

286+
/**
287+
* @group transient-on-windows
288+
*/
274289
public function testItUseBlocksFromEmbeddedContextUsingMultipleComponentsWithNamespacedTemplate()
275290
{
276291
$templateName = 'render_multiple_embedded_with_blocks.html.twig';

src/LiveComponent/tests/Integration/LiveComponentHydratorTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ private function executeHydrationTestCase(callable $testFactory, ?int $minPhpVer
151151
}
152152

153153
/**
154+
* @group transient-on-windows
154155
* @dataProvider provideDehydrationHydrationTests
155156
*/
156157
public function testCanDehydrateAndHydrateComponentWithTestCases(callable $testFactory, ?int $minPhpVersion = null)

0 commit comments

Comments
 (0)