bug #1268 Remove "type": "module" from all package.json files (smnandre)

weaverryan · weaverryan · commit a7fdbf897791 · 2023-11-10T20:20:33.000-05:00
This PR was squashed before being merged into the 2.x branch. Discussion ---------- Remove "type": "module" from all package.json files Since #1264, another person could not build its assets with Encore and a babel plugin. So for now we decided to revert the "type: module" declaration. ### Revert the "type: module" Remove this "type" line from all package.json files and revert replacing "main:" with "module:" Before ```json "type": "module", "module": "dist/foo.js", ``` After ```json "main": "dist/foo.js", ``` ### Fix Svelte ESM bug with vite/vitest ``` We recommend converting your config to ESM by either: adding "type": "module" to the nearest package.json renaming vite.config.js/vite.config.ts to vite.config.mjs/vite.config.mts ``` (https://vitejs.dev/guide/troubleshooting.html#config) So i used the second one.... and it seems to work Commits ------- 919ade7 Remove "type": "module" from all package.json files
diff --git a/src/Autocomplete/CHANGELOG.md b/src/Autocomplete/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.13.2
+
+-   Revert "Change JavaScript package to `type: module`"
+
 ## 2.13.0
 
 -   Add new BaseEntityAutocompleteType
diff --git a/src/Autocomplete/assets/package.json b/src/Autocomplete/assets/package.json
@@ -1,8 +1,7 @@
 {
     "name": "@symfony/ux-autocomplete",
     "description": "JavaScript-powered autocompletion functionality for forms.",
-    "module": "dist/controller.js",
-    "type": "module",
+    "main": "dist/controller.js",
     "types": "dist/controller.d.ts",
     "version": "1.0.0",
     "license": "MIT",
diff --git a/src/Chartjs/CHANGELOG.md b/src/Chartjs/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.13.2
+
+-   Revert "Change JavaScript package to `type: module`"
+
 ## 2.13.0
 
 -   Add Symfony 7 support.
diff --git a/src/Chartjs/assets/package.json b/src/Chartjs/assets/package.json
@@ -3,7 +3,7 @@
     "description": "Chart.js integration for Symfony",
     "license": "MIT",
     "version": "1.1.0",
-    "module": "dist/controller.js",
+    "main": "dist/controller.js",
     "types": "dist/controller.d.ts",
     "symfony": {
         "controllers": {
diff --git a/src/Cropperjs/CHANGELOG.md b/src/Cropperjs/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.13.2
+
+-   Revert "Change JavaScript package to `type: module`"
+
 ## 2.13.0
 
 -   Add Symfony 7 support.
diff --git a/src/Cropperjs/assets/package.json b/src/Cropperjs/assets/package.json
@@ -3,8 +3,7 @@
     "description": "Cropper.js integration for Symfony",
     "license": "MIT",
     "version": "1.1.0",
-    "module": "dist/controller.js",
-    "type": "module",
+    "main": "dist/controller.js",
     "types": "dist/controller.d.ts",
     "config": {
         "css_source": "src/style.css"
diff --git a/src/Dropzone/CHANGELOG.md b/src/Dropzone/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.13.2
+
+-   Revert "Change JavaScript package to `type: module`"
+
 ## 2.13.0
 
 -   Add Symfony 7 support.
diff --git a/src/Dropzone/assets/package.json b/src/Dropzone/assets/package.json
@@ -3,8 +3,7 @@
     "description": "File input dropzones for Symfony Forms",
     "license": "MIT",
     "version": "1.1.0",
-    "module": "dist/controller.js",
-    "type": "module",
+    "main": "dist/controller.js",
     "types": "dist/controller.d.ts",
     "config": {
         "css_source": "src/style.css"
diff --git a/src/LazyImage/CHANGELOG.md b/src/LazyImage/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.13.2
+
+-   Revert "Change JavaScript package to `type: module`"
+
 ## 2.13.0
 
 -   Add Symfony 7 support.
diff --git a/src/LazyImage/assets/package.json b/src/LazyImage/assets/package.json
@@ -3,8 +3,7 @@
     "description": "Lazy image loader and utilities for Symfony",
     "license": "MIT",
     "version": "1.1.0",
-    "module": "dist/controller.js",
-    "type": "module",
+    "main": "dist/controller.js",
     "types": "dist/controller.d.ts",
     "symfony": {
         "controllers": {
diff --git a/src/LiveComponent/CHANGELOG.md b/src/LiveComponent/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.13.2
+
+-   Revert "Change JavaScript package to `type: module`"
+
 ## 2.13.0
 
 -   Add deferred/lazy rendering of Live Components.
diff --git a/src/LiveComponent/assets/package.json b/src/LiveComponent/assets/package.json
@@ -1,8 +1,7 @@
 {
     "name": "@symfony/ux-live-component",
     "description": "Live Component: bring server-side re-rendering & model binding to any element.",
-    "module": "dist/live_controller.js",
-    "type": "module",
+    "main": "dist/live_controller.js",
     "types": "dist/live_controller.d.ts",
     "version": "1.0.0",
     "config": {
diff --git a/src/Notify/CHANGELOG.md b/src/Notify/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.13.2
+
+-   Revert "Change JavaScript package to `type: module`"
+
 ## 2.13.0
 
 -   Add Symfony 7 support.
diff --git a/src/Notify/assets/package.json b/src/Notify/assets/package.json
@@ -3,8 +3,7 @@
     "description": "Native notification integration for Symfony using Mercure",
     "license": "MIT",
     "version": "1.0.0",
-    "module": "dist/controller.js",
-    "type": "module",
+    "main": "dist/controller.js",
     "types": "dist/controller.d.ts",
     "symfony": {
         "controllers": {
diff --git a/src/React/CHANGELOG.md b/src/React/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.13.2
+
+-   Revert "Change JavaScript package to `type: module`"
+
 ## 2.13.0
 
 -   Add Symfony 7 support.
diff --git a/src/React/assets/package.json b/src/React/assets/package.json
@@ -3,8 +3,7 @@
     "description": "Integration of React in Symfony",
     "license": "MIT",
     "version": "1.0.0",
-    "module": "dist/register_controller.js",
-    "type": "module",
+    "main": "dist/register_controller.js",
     "types": "dist/register_controller.d.ts",
     "symfony": {
         "controllers": {
diff --git a/src/StimulusBundle/CHANGELOG.md b/src/StimulusBundle/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.13.2
+
+-   Revert "Change JavaScript package to `type: module`"
+
 ## 2.13.0
 
 -   Normalize parameters names given to twig helper 'stimulus_action()'.
diff --git a/src/StimulusBundle/assets/package.json b/src/StimulusBundle/assets/package.json
@@ -3,8 +3,7 @@
     "description": "Integration of @hotwired/stimulus into Symfony",
     "version": "1.0.0",
     "license": "MIT",
-    "module": "dist/loader.js",
-    "type": "module",
+    "main": "dist/loader.js",
     "symfony": {
         "needsPackageAsADependency": false,
         "importmap": {
diff --git a/src/Svelte/CHANGELOG.md b/src/Svelte/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.13.2
+
+-   Revert "Change JavaScript package to `type: module`"
+
 ## 2.13.0
 
 -   Add support for Svelte 4.
diff --git a/src/Svelte/assets/package.json b/src/Svelte/assets/package.json
@@ -1,8 +1,7 @@
 {
     "name": "@symfony/ux-svelte",
     "description": "Integration of Svelte in Symfony",
-    "module": "dist/register_controller.js",
-    "type": "module",
+    "main": "dist/register_controller.js",
     "version": "1.0.0",
     "license": "MIT",
     "symfony": {
diff --git a/src/Svelte/assets/vitest.config.mjs b/src/Svelte/assets/vitest.config.mjs
diff --git a/src/Swup/CHANGELOG.md b/src/Swup/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.13.2
+
+-   Revert "Change JavaScript package to `type: module`"
+
 ## 2.13.0
 
 -   Change JavaScript package to `type: module`
diff --git a/src/Swup/assets/package.json b/src/Swup/assets/package.json
@@ -3,8 +3,7 @@
     "description": "Swup integration for Symfony",
     "license": "MIT",
     "version": "1.1.0",
-    "module": "dist/controller.js",
-    "type": "module",
+    "main": "dist/controller.js",
     "types": "dist/controller.d.ts",
     "symfony": {
         "controllers": {
diff --git a/src/TogglePassword/CHANGELOG.md b/src/TogglePassword/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.13.2
+
+-   Revert "Change JavaScript package to `type: module`"
+
 ## 2.13.0
 
 -   Add Symfony 7 support.
diff --git a/src/TogglePassword/assets/package.json b/src/TogglePassword/assets/package.json
@@ -3,8 +3,7 @@
     "description": "Toggle visibility of password inputs for Symfony Forms",
     "license": "MIT",
     "version": "1.0.0",
-    "module": "dist/controller.js",
-    "type": "module",
+    "main": "dist/controller.js",
     "types": "dist/controller.d.ts",
     "config": {
         "css_source": "src/style.css"
diff --git a/src/Translator/CHANGELOG.md b/src/Translator/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.13.2
+
+-   Revert "Change JavaScript package to `type: module`"
+
 ## 2.13.0
 
 -   Add Symfony 7 support.
diff --git a/src/Translator/assets/package.json b/src/Translator/assets/package.json
@@ -3,8 +3,7 @@
     "description": "Symfony Translator for JavaScript",
     "license": "MIT",
     "version": "1.0.0",
-    "module": "dist/translator_controller.js",
-    "type": "module",
+    "main": "dist/translator_controller.js",
     "types": "dist/translator_controller.d.ts",
     "symfony": {
         "importmap": {
diff --git a/src/Turbo/CHANGELOG.md b/src/Turbo/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.13.2
+
+-   Revert "Change JavaScript package to `type: module`"
+
 ## 2.13.0
 
 -   Add Symfony 7 support.
diff --git a/src/Turbo/assets/package.json b/src/Turbo/assets/package.json
@@ -4,8 +4,7 @@
     "license": "MIT",
     "private": true,
     "version": "0.1.0",
-    "module": "dist/turbo_controller.js",
-    "type": "module",
+    "main": "dist/turbo_controller.js",
     "types": "dist/turbo_controller.d.ts",
     "symfony": {
         "controllers": {
diff --git a/src/Typed/CHANGELOG.md b/src/Typed/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.13.2
+
+-   Revert "Change JavaScript package to `type: module`"
+
 ## 2.13.0
 
 -   Change JavaScript package to `type: module`
diff --git a/src/Typed/assets/package.json b/src/Typed/assets/package.json
@@ -3,8 +3,7 @@
     "description": "Typed integration for Symfony",
     "license": "MIT",
     "version": "1.0.0",
-    "module": "dist/controller.js",
-    "type": "module",
+    "main": "dist/controller.js",
     "types": "dist/controller.d.ts",
     "symfony": {
         "controllers": {
diff --git a/src/Vue/CHANGELOG.md b/src/Vue/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.13.2
+
+-   Revert "Change JavaScript package to `type: module`"
+
 ## 2.13.0
 
 -   Add Symfony 7 support.
diff --git a/src/Vue/assets/package.json b/src/Vue/assets/package.json
@@ -3,8 +3,7 @@
     "description": "Integration of Vue.js in Symfony",
     "license": "MIT",
     "version": "1.0.0",
-    "module": "dist/register_controller.js",
-    "type": "module",
+    "main": "dist/register_controller.js",
     "types": "dist/register_controller.d.ts",
     "symfony": {
         "controllers": {
