improved tests

Author: Jean-François Lépine

src/Toolkit/phpunit.xml.dist

@@ -22,4 +22,9 @@
   <listeners>
     <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener"/>
   </listeners>
+  <coverage>
+    <include>
+      <directory suffix=".php">src</directory>
+    </include>
+  </coverage>
 </phpunit>

src/Toolkit/src/Registry/DependenciesResolver.php

@@ -24,8 +24,8 @@ public function resolve(Registry $registry): array
         $unresolved = [];
 
         $concernedComponents = [];
-        foreach($registry->all() as $item) {
-            if ($item->type !== RegistryItemType::Component) {
+        foreach ($registry->all() as $item) {
+            if (RegistryItemType::Component !== $item->type) {
                 continue;
             }
 

src/Toolkit/src/Registry/RegistryItem.php

@@ -83,7 +83,7 @@ public static function fromTwigFile(SplFileInfo $file): self
         if ($name === $parentName) {
             $parentName = null;
         }
-        // @todo: we should improve the way to detect examples
+        // @todo: we should improve the way we detect examples
         $isExample = preg_match('#examples#', $file->getRelativePathname());
         $type = $isExample ? RegistryItemType::Example : RegistryItemType::Component;
         $theme = '';

src/Toolkit/tests/Command/UxToolkitInstallCommandTest.php

@@ -11,12 +11,12 @@
 
 namespace Symfony\UX\Toolkit\Tests\Command;
 
-use PHPUnit\Framework\TestCase;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Zenstruck\Console\Test\InteractsWithConsole;
 
 /**
  * @author Jean-François Lépine
+ *
  * @group wip
  */
 class UxToolkitInstallCommandTest extends KernelTestCase
@@ -43,4 +43,32 @@ public function testShouldAbleToCreateTheBadgeComponent(): void
         $actualContent = file_get_contents($expectedFile);
         $this->assertEquals($expectedContent, $actualContent);
     }
+
+    public function testShouldFailWhenComponentDoesNotExist(): void
+    {
+        $destination = sys_get_temp_dir().\DIRECTORY_SEPARATOR.uniqid();
+        mkdir($destination);
+
+        $this->bootKernel();
+        $this->consoleCommand('ux:toolkit:install unknown --destination='.$destination)
+            ->execute()
+            ->assertFaulty()
+            ->assertOutputContains('The component "Unknown" does not exist.');
+    }
+
+    public function testShouldFailWhenComponentFileAlreadyExistsInNonInteractiveMode(): void
+    {
+        $destination = sys_get_temp_dir().\DIRECTORY_SEPARATOR.uniqid();
+        mkdir($destination);
+
+        $this->bootKernel();
+        $this->consoleCommand('ux:toolkit:install badge --destination='.$destination)
+            ->execute()
+            ->assertSuccessful();
+
+        $this->consoleCommand('ux:toolkit:install badge --destination='.$destination)
+            ->execute()
+            ->assertFaulty()
+            ->assertOutputContains('The component "Badge" already exists.');
+    }
 }

src/Toolkit/tests/DependencyInjection/ToolkitExtensionTest.php

@@ -0,0 +1,46 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\UX\Toolkit\Tests\DependencyInjection;
+
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\UX\Toolkit\DependencyInjection\ToolkitExtension;
+
+/**
+ * @author Jean-François Lépine
+ */
+class ToolkitExtensionTest extends TestCase
+{
+    public function testGetAlias(): void
+    {
+        $extension = new ToolkitExtension();
+        $this->assertEquals('ux_toolkit', $extension->getAlias());
+    }
+
+    public function testLoadInjectUsefulParameters(): void
+    {
+        $configs = [
+            'prefix' => 'Acme',
+            'theme' => 'default',
+        ];
+
+        $container = new ContainerBuilder();
+        $extension = new ToolkitExtension();
+        $extension->load([$configs], $container);
+
+        $this->assertTrue($container->hasParameter('ux_toolkit.prefix'));
+        $this->assertEquals('Acme', $container->getParameter('ux_toolkit.prefix'));
+
+        $this->assertTrue($container->hasParameter('ux_toolkit.theme'));
+        $this->assertEquals('default', $container->getParameter('ux_toolkit.theme'));
+    }
+}

src/Toolkit/tests/UxToolkitBundleTest.php

@@ -0,0 +1,32 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\UX\Toolkit\Tests;
+
+use PHPUnit\Framework\TestCase;
+use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\UX\Toolkit\DependencyInjection\ToolkitExtension;
+use Symfony\UX\Toolkit\UxToolkitBundle;
+
+/**
+ * @author Jean-François Lépine
+ */
+class UxToolkitBundleTest extends KernelTestCase
+{
+    public function testBundleBuildsSuccessfully(): void
+    {
+        self::bootKernel();
+        $container = self::$kernel->getContainer();
+
+        $this->assertInstanceOf(UxToolkitBundle::class, $container->get('kernel')->getBundles()['UxToolkitBundle']);
+    }
+}