allow marker, polygone and polyline removal

Author: sblondeau

src/Icons/config/twig_component.php

@@ -12,7 +12,6 @@
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;
 
 use Symfony\UX\Icons\Twig\UXIconComponent;
-use Symfony\UX\Icons\Twig\UXIconComponentListener;
 
 return static function (ContainerConfigurator $container): void {
     $container->services()

src/LiveComponent/tests/Functional/EventListener/LiveComponentSubscriberTest.php

@@ -12,8 +12,6 @@
 namespace Symfony\UX\LiveComponent\Tests\Functional\EventListener;
 
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
-use Symfony\Component\DomCrawler\Crawler;
-use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 use Symfony\Component\Security\Core\User\InMemoryUser;
 use Symfony\Component\Security\Http\Attribute\IsGranted;
 use Symfony\UX\LiveComponent\Tests\Fixtures\Entity\Entity1;

src/LiveComponent/tests/Integration/EventListener/DataModelPropsSubscriberTest.php

@@ -12,7 +12,6 @@
 namespace Symfony\UX\LiveComponent\Tests\Integration\EventListener;
 
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
-use Symfony\Component\HttpFoundation\Request;
 use Symfony\UX\LiveComponent\Tests\LiveComponentTestHelper;
 use Symfony\UX\TwigComponent\ComponentRenderer;
 

src/LiveComponent/tests/Integration/LiveComponentHydratorTest.php

@@ -978,7 +978,7 @@ public function mount()
 
             return HydrationTest::create(new class {
                 /**
-                 * @var \Symfony\UX\LiveComponent\Tests\Fixtures\Dto\Address[]
+                 * @var Address[]
                  */
                 #[LiveProp(writable: true, useSerializerForHydration: true)]
                 public array $addresses = [];
@@ -1009,7 +1009,7 @@ public function mount()
 
             return HydrationTest::create(new class {
                 /**
-                 * @var \Symfony\UX\LiveComponent\Tests\Fixtures\Dto\Address[]
+                 * @var Address[]
                  */
                 #[LiveProp(writable: true, useSerializerForHydration: true)]
                 public array $addresses = [];
@@ -1037,7 +1037,7 @@ public function mount()
         yield 'Array with DTOs: fully writable allows deep partial changes' => [function () {
             return HydrationTest::create(new class {
                 /**
-                 * @var \Symfony\UX\LiveComponent\Tests\Fixtures\Dto\HoldsArrayOfDtos[] $dtos
+                 * @var HoldsArrayOfDtos[] $dtos
                  */
                 #[LiveProp(writable: true, useSerializerForHydration: true)]
                 public array $dtos = [];
@@ -1157,7 +1157,7 @@ public function mount()
 
         yield 'Collection: using serializer (de)hydrates correctly' => [function () {
             return HydrationTest::create(new class {
-                /** @var \Symfony\UX\LiveComponent\Tests\Fixtures\Dto\Temperature[] */
+                /** @var Temperature[] */
                 #[LiveProp(useSerializerForHydration: true)]
                 public array $temperatures = [];
 

src/Map/CHANGELOG.md

@@ -8,6 +8,11 @@
    `HaversineDistanceCalculator`, `SphericalCosineDistanceCalculator` and `VincentyDistanceCalculator`.
 -  Add `CoordinateUtils` helper, to convert decimal coordinates (`43.2109`) in DMS (`56° 78' 90"`)
 
+-  Add property `$id` to Marker`, `Polygon` and `Polyline` constructors
+-  Add method `Symfony\UX\Map::removeMarker(string|Marker $markerOrId)`, to allow removal of a marker from its identifier
+-  Add method `Symfony\UX\Map::removePolygon(string|Polygon $markerOrId)`, to allow removal of a polygon from its identifier
+-  Add method `Symfony\UX\Map::removePolyline(string|Polyline $markerOrId)`, to allow removal of a polyline from its identifier
+
 ## 2.22
 
 -   Add method `Symfony\UX\Map\Renderer\AbstractRenderer::tapOptions()`, to allow Renderer to modify options before rendering a Map.

src/Map/doc/index.rst

@@ -136,10 +136,37 @@ You can add markers to a map using the ``addMarker()`` method::
         ))
     ;
 
+Remove elements from Map
+~~~~~~~~~~~~~~~~~~~~~~~~
+
+It is possible to remove elements like ``Marker``, ``Polygon`` and ``Polyline`` instances by using methods ``Map::remove*()``:
+    // Add elements
+    $map->addMarker($marker = new Marker(/* ... */));
+    $map->addPolygon($polygon = new Polygon(/* ... */));
+    $map->addPolyline($polyline = new Polyline(/* ... */));
+    
+    // And later, remove those elements
+    $map->removeMarker($marker);
+    $map->removePolygon($polygon);
+    $map->removePolyline($polyline);
+    
+If unfortunately you were unable to store an element instance, you can still remove them by passing the identifier string:
+ 
+    $map = new Map(/* ... */);
+    // Add elements
+    $map->addMarker(new Marker(id: 'my-marker', /* ... */));
+    $map->addPolygon(new Polygon(id: 'my-polygon', /* ... */));
+    $map->addPolyline(new Polyline(id: 'my-marker', /* ... */));
+    
+    // And later, remove those elements
+    $map->removeMarker('my-marker');
+    $map->removePolygon('my-polygon');
+    $map->removePolyline('my-marker');
+
 Add Polygons
 ~~~~~~~~~~~~
 
-You can also add Polygons, which represents an area enclosed by a series of ``Point`` instances::
+You can also add Polygons, which represents an area enclosed by a series of ``Point`` instances:
 
     $myMap->addPolygon(new Polygon(
         points: [
@@ -156,7 +183,7 @@ You can also add Polygons, which represents an area enclosed by a series of ``Po
 Add Polylines
 ~~~~~~~~~~~~~
 
-You can add Polylines, which represents a path made by a series of ``Point`` instances::
+You can add Polylines, which represents a path made by a series of ``Point`` instances:
 
     $myMap->addPolyline(new Polyline(
         points: [