Skip to content

Commit aee1e08

Browse files
committed
debug
1 parent e7db902 commit aee1e08

File tree

5 files changed

+7275
-23
lines changed

5 files changed

+7275
-23
lines changed

.github/workflows/app-tests.yaml

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -54,30 +54,29 @@ jobs:
5454
run: php .github/build-packages.php
5555

5656
# We always install PHP deps because of the UX Translator, which requires `var/translations` to exists
57-
- name: Install App dependencies
57+
- name: Install PHP dependencies
5858
uses: ramsey/composer-install@v3
5959
with:
6060
working-directory: test_apps/encore-app
6161
dependency-versions: highest
6262

63-
- if: matrix.ux-packages-source == 'php-vendor'
64-
name: Refresh dependencies from vendor/
65-
working-directory: test_apps/encore-app
63+
- working-directory: test_apps/encore-app
6664
run: pnpm install
6765

6866
- if: matrix.ux-packages-source == 'js-packages'
6967
name: Install UX JS packages with a JS package manager
7068
working-directory: test_apps/encore-app
7169
run: |
7270
PACKAGES_TO_INSTALL=''
73-
for PACKAGE in $(cd ../..; pnpm ls -r --json --depth -1 | jq 'map(select(.private != true))'); do
74-
PACKAGE_DIR=../../$(echo $PACKAGE | jq -r '.path')
75-
PACKAGES_TO_INSTALL="$PACKAGES_TO_INSTALL $PACKAGE_DIR"
71+
for PACKAGE in $(cd ../..; pnpm ls -r --json --depth -1 | jq 'map(select(.private != true))' | jq -c '.[]'); do
72+
PACKAGE_ABSOLUTE_PATH=$(echo $PACKAGE | jq -r '.path')
73+
PACKAGE_RELATIVE_PATH=$(realpath --relative-to=. "$PACKAGE_ABSOLUTE_PATH")
74+
PACKAGES_TO_INSTALL="$PACKAGES_TO_INSTALL $PACKAGE_RELATIVE_PATH"
7675
done
7776
echo "Installing packages: $PACKAGES_TO_INSTALL"
7877
pnpm add --save-dev $PACKAGES_TO_INSTALL
7978
80-
- name: Ensure UX packages are installed from "${{ matrix.ux-packages-source == 'php-vendor' && 'vendor/symfony/ux-...' || '../../../src/**/assets' }}"
79+
- name: Ensure UX packages are installed from "${{ env.EXPECTED_PATTERN }}"
8180
working-directory: test_apps/encore-app
8281
run: |
8382
for PACKAGE in $(cat package.json | jq -c '(.dependencies // {}) + (.devDependencies // {}) | to_entries[] | select(.key | startswith("@symfony/ux-")) | {name: .key, version: .value}'); do
@@ -94,12 +93,12 @@ jobs:
9493
fi
9594
done;
9695
env:
97-
EXPECTED_PATTERN: ${{ matrix.ux-packages-source == 'php-vendor' && 'file:vendor/symfony/*' || '../../src/*' }}
96+
EXPECTED_PATTERN: ${{ matrix.ux-packages-source == 'php-vendor' && 'file:vendor/symfony/*' || 'link:../../src/*' }}
9897

99-
- name: Run Encore (dev)
98+
- name: Ensure project can be built in dev mode
10099
working-directory: test_apps/encore-app
101-
run: pnpm run encore dev
100+
run: pnpm run dev
102101

103-
- name: Run Encore (prod)
102+
- name: Ensure project can be built in prod mode
104103
working-directory: test_apps/encore-app
105-
run: pnpm run encore production
104+
run: pnpm run build

test_apps/encore-app/.gitignore

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,5 @@
11
composer.lock
22

3-
.yarn/*
4-
!.yarn/cache
5-
!.yarn/patches
6-
!.yarn/plugins
7-
!.yarn/releases
8-
!.yarn/sdks
9-
!.yarn/versions
10-
/node_modules
11-
yarn-error.log
12-
133
###> symfony/framework-bundle ###
144
/.env.local
155
/.env.local.php

test_apps/encore-app/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
"devDependencies": {
33
"@babel/core": "^7.17.0",
44
"@babel/preset-env": "^7.16.0",
5+
"@babel/preset-react": "^7.27.1",
56
"@googlemaps/js-api-loader": "^1.16.6",
67
"@hotwired/stimulus": "^3.0.0",
78
"@hotwired/turbo": "^7.1.1 || ^8.0",

0 commit comments

Comments
 (0)