@@ -54,30 +54,29 @@ jobs:
54
54
run : php .github/build-packages.php
55
55
56
56
# We always install PHP deps because of the UX Translator, which requires `var/translations` to exists
57
- - name : Install App dependencies
57
+ - name : Install PHP dependencies
58
58
uses : ramsey/composer-install@v3
59
59
with :
60
60
working-directory : test_apps/encore-app
61
61
dependency-versions : highest
62
62
63
- - if : matrix.ux-packages-source == 'php-vendor'
64
- name : Refresh dependencies from vendor/
65
- working-directory : test_apps/encore-app
63
+ - working-directory : test_apps/encore-app
66
64
run : pnpm install
67
65
68
66
- if : matrix.ux-packages-source == 'js-packages'
69
67
name : Install UX JS packages with a JS package manager
70
68
working-directory : test_apps/encore-app
71
69
run : |
72
70
PACKAGES_TO_INSTALL=''
73
- for PACKAGE in $(cd ../..; pnpm ls -r --json --depth -1 | jq 'map(select(.private != true))'); do
74
- PACKAGE_DIR=../../$(echo $PACKAGE | jq -r '.path')
75
- PACKAGES_TO_INSTALL="$PACKAGES_TO_INSTALL $PACKAGE_DIR"
71
+ for PACKAGE in $(cd ../..; pnpm ls -r --json --depth -1 | jq 'map(select(.private != true))' | jq -c '.[]'); do
72
+ PACKAGE_ABSOLUTE_PATH=$(echo $PACKAGE | jq -r '.path')
73
+ PACKAGE_RELATIVE_PATH=$(realpath --relative-to=. "$PACKAGE_ABSOLUTE_PATH")
74
+ PACKAGES_TO_INSTALL="$PACKAGES_TO_INSTALL $PACKAGE_RELATIVE_PATH"
76
75
done
77
76
echo "Installing packages: $PACKAGES_TO_INSTALL"
78
77
pnpm add --save-dev $PACKAGES_TO_INSTALL
79
78
80
- - name : Ensure UX packages are installed from "${{ matrix.ux-packages-source == 'php-vendor' && 'vendor/symfony/ux-...' || '../../../src/**/assets' }}"
79
+ - name : Ensure UX packages are installed from "${{ env.EXPECTED_PATTERN }}"
81
80
working-directory : test_apps/encore-app
82
81
run : |
83
82
for PACKAGE in $(cat package.json | jq -c '(.dependencies // {}) + (.devDependencies // {}) | to_entries[] | select(.key | startswith("@symfony/ux-")) | {name: .key, version: .value}'); do
@@ -94,12 +93,12 @@ jobs:
94
93
fi
95
94
done;
96
95
env :
97
- EXPECTED_PATTERN : ${{ matrix.ux-packages-source == 'php-vendor' && 'file:vendor/symfony/*' || '../../src/*' }}
96
+ EXPECTED_PATTERN : ${{ matrix.ux-packages-source == 'php-vendor' && 'file:vendor/symfony/*' || 'link: ../../src/*' }}
98
97
99
- - name : Run Encore ( dev)
98
+ - name : Ensure project can be built in dev mode
100
99
working-directory : test_apps/encore-app
101
- run : pnpm run encore dev
100
+ run : pnpm run dev
102
101
103
- - name : Run Encore ( prod)
102
+ - name : Ensure project can be built in prod mode
104
103
working-directory : test_apps/encore-app
105
- run : pnpm run encore production
104
+ run : pnpm run build
0 commit comments