Skip to content

Commit bd1279d

Browse files
mercuryseriesKocal
authored andcommitted
fix: handle empty string in data-value attribute correctly
1 parent 30c3a2e commit bd1279d

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/LiveComponent/assets/dist/live_controller.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ function getValueFromElement(element, valueStore) {
377377
}
378378
return element.value;
379379
}
380-
if (element.dataset.value) {
380+
if (element.hasAttribute("data-value")) {
381381
return element.dataset.value;
382382
}
383383
if ("value" in element) {

src/LiveComponent/assets/src/dom_utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export function getValueFromElement(element: HTMLElement, valueStore: ValueStore
5151
}
5252

5353
// element is some other element
54-
if (element.dataset.value) {
54+
if (element.hasAttribute("data-value")) {
5555
return element.dataset.value;
5656
}
5757

0 commit comments

Comments
 (0)