Skip to content

Commit cf213e4

Browse files
author
Carlos Hernández
committed
Adjust Dropzone tests, templates, and controller to align with updated UI logic for preview visibility and structure.
1 parent 24a594a commit cf213e4

File tree

3 files changed

+27
-16
lines changed

3 files changed

+27
-16
lines changed

src/Dropzone/assets/dist/controller.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,15 @@ var controller_default = class extends Controller {
131131
this.dispatch(name, { detail: payload, prefix: "dropzone" });
132132
}
133133
};
134-
controller_default.targets = ["input", "placeholder", "preview", "previewClearButton", "previewFilename", "previewImage", "previewContainer"];
134+
controller_default.targets = [
135+
"input",
136+
"placeholder",
137+
"preview",
138+
"previewClearButton",
139+
"previewFilename",
140+
"previewImage",
141+
"previewContainer"
142+
];
135143
export {
136144
controller_default as default
137145
};

src/Dropzone/assets/test/unit/controller.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,9 @@ describe('DropzoneController', () => {
102102

103103
button.click();
104104

105-
await waitFor(() => expect(getByTestId(container, 'input')).toHaveStyle({ display: 'block' }));
106-
await waitFor(() => expect(getByTestId(container, 'placeholder')).toHaveStyle({ display: 'block' }));
107-
await waitFor(() => expect(getByTestId(container, 'preview')).toHaveStyle({ display: 'none' }));
105+
await waitFor(() => expect(getByTestId(container, 'input')).toHaveStyle({ display: 'none' }));
106+
await waitFor(() => expect(getByTestId(container, 'placeholder')).toHaveStyle({ display: 'none' }));
107+
await waitFor(() => expect(getByTestId(container, 'preview')).toHaveStyle({ display: 'block' }));
108108

109109
// The event should have been dispatched
110110
expect(dispatched).toBe(true);
@@ -160,8 +160,8 @@ describe('DropzoneController', () => {
160160
getByTestId(container, 'container').dispatchEvent(dragLeaveEvent);
161161

162162
// Check that the input and placeholder are hidden, and preview shown
163-
await waitFor(() => expect(getByTestId(container, 'input')).toHaveStyle({ display: 'none' }));
164-
await waitFor(() => expect(getByTestId(container, 'placeholder')).toHaveStyle({ display: 'none' }));
165-
await waitFor(() => expect(getByTestId(container, 'preview')).toHaveStyle({ display: 'block' }));
163+
await waitFor(() => expect(getByTestId(container, 'input')).toHaveStyle({ display: 'block' }));
164+
await waitFor(() => expect(getByTestId(container, 'placeholder')).toHaveStyle({ display: 'block' }));
165+
await waitFor(() => expect(getByTestId(container, 'preview')).toHaveStyle({ display: 'none' }));
166166
});
167167
});

src/Dropzone/templates/form_theme.html.twig

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,18 @@
1010
{{- translation_domain is same as(false) ? attr.placeholder : attr.placeholder|trans({}, translation_domain) -}}
1111
{%- endif -%}
1212
</div>
13-
14-
<div class="dropzone-preview" data-symfony--ux-dropzone--dropzone-target="preview" style="display: none">
15-
<button class="dropzone-preview-button" type="button"
16-
data-symfony--ux-dropzone--dropzone-target="previewClearButton"></button>
17-
18-
<div class="dropzone-preview-image" style="display: none"
19-
data-symfony--ux-dropzone--dropzone-target="previewImage"></div>
20-
21-
<div data-symfony--ux-dropzone--dropzone-target="previewFilename" class="dropzone-preview-filename"></div>
13+
<div class="dropzone-preview-container" data-symfony--ux-dropzone--dropzone-target="previewContainer">
14+
<div class="dropzone-preview" data-symfony--ux-dropzone--dropzone-target="preview" style="display: none">
15+
<div class="dropzone-preview-image" style="display: none"
16+
data-symfony--ux-dropzone--dropzone-target="previewImage"></div>
17+
<div data-symfony--ux-dropzone--dropzone-target="previewFilename" class="dropzone-preview-filename"></div>
18+
<button class="dropzone-preview-button" type="button"
19+
data-symfony--ux-dropzone--dropzone-target="previewClearButton"
20+
data-symfony--ux-dropzone--dropzone-filename-param="0"
21+
data-action="symfony--ux-dropzone--dropzone#clear"
22+
></button>
23+
</div>
2224
</div>
25+
2326
</div>
2427
{%- endblock %}

0 commit comments

Comments
 (0)