fabbot

Author: smnandre

src/Icons/src/Command/ImportIconCommand.php

@@ -66,7 +66,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         }
 
         foreach ($prefixIcons as $prefix => $icons) {
-
             if (!$this->iconify->hasIconSet($prefix)) {
                 $io->error(\sprintf('Icon set "%s" not found.', $prefix));
                 $result = Command::FAILURE;
@@ -78,46 +77,45 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $io->newLine();
             $io->writeln(\sprintf(' Icon set: %s (License: %s)', $metadata['name'], $metadata['license']['title']));
 
-            foreach ($this->iconify->chunk($prefix, \array_keys($icons)) as $iconNames) {
-
+            foreach ($this->iconify->chunk($prefix, array_keys($icons)) as $iconNames) {
                 $cursor = new Cursor($output);
                 foreach ($iconNames as $name) {
                     $io->writeln(\sprintf('  Importing %s:%s ...', $prefix, $name));
                 }
-                $cursor->moveUp(count($iconNames));
+                $cursor->moveUp(\count($iconNames));
 
                 try {
                     $batchResults = $this->iconify->fetchIcons($prefix, $iconNames);
                 } catch (\InvalidArgumentException $e) {
                     // At this point no exception should be thrown
                     $io->error($e->getMessage());
 
-                    return COMMAND::FAILURE;
+                    return Command::FAILURE;
                 }
 
                 foreach ($iconNames as $name) {
                     $cursor->clearLineAfter();
 
                     // If the icon is not found, the value will be null
                     if (null === $icon = $batchResults[$name] ?? null) {
-                        $io->writeln(\sprintf(" <fg=red;options=bold>✗</> Not Found <fg=bright-white;bg=black>%s:</><fg=bright-red;bg=black>%s</>", $prefix, $name));
+                        $io->writeln(\sprintf(' <fg=red;options=bold>✗</> Not Found <fg=bright-white;bg=black>%s:</><fg=bright-red;bg=black>%s</>', $prefix, $name));
 
                         continue;
                     }
 
                     ++$importedIcons;
                     $this->registry->add(\sprintf('%s/%s', $prefix, $name), (string) $icon);
-                    $io->writeln(\sprintf(" <fg=bright-green;options=bold>✓</> Imported <fg=bright-white;bg=black>%s:</><fg=bright-magenta;bg=black;options>%s</>", $prefix, $name));
+                    $io->writeln(\sprintf(' <fg=bright-green;options=bold>✓</> Imported <fg=bright-white;bg=black>%s:</><fg=bright-magenta;bg=black;options>%s</>', $prefix, $name));
                 }
             }
         }
 
-        if ($importedIcons === $totalIcons = count($names)) {
-            $io->success(sprintf('Imported %d/%d icons.', $importedIcons, $totalIcons));
+        if ($importedIcons === $totalIcons = \count($names)) {
+            $io->success(\sprintf('Imported %d/%d icons.', $importedIcons, $totalIcons));
         } elseif ($importedIcons > 0) {
-            $io->warning(sprintf('Imported %d/%d icons.', $importedIcons, $totalIcons));
+            $io->warning(\sprintf('Imported %d/%d icons.', $importedIcons, $totalIcons));
         } else {
-            $io->error(sprintf('Imported %d/%d icons.', $importedIcons, $totalIcons));
+            $io->error(\sprintf('Imported %d/%d icons.', $importedIcons, $totalIcons));
             $result = Command::FAILURE;
         }
 

src/Icons/src/Iconify.php

@@ -165,17 +165,17 @@ public function searchIcons(string $prefix, string $query)
      */
     public function chunk(string $prefix, array $names): iterable
     {
-        if (100 < ($prefixLength = strlen($prefix))) {
-            throw new \InvalidArgumentException(sprintf('The icon prefix "%s" is too long.', $prefix));
+        if (100 < ($prefixLength = \strlen($prefix))) {
+            throw new \InvalidArgumentException(\sprintf('The icon prefix "%s" is too long.', $prefix));
         }
 
         $maxLength = $this->maxIconsQueryLength - $prefixLength;
 
         $curBatch = [];
         $curLength = 0;
         foreach ($names as $name) {
-            if (100 < ($nameLength = strlen($name))) {
-                throw new \InvalidArgumentException(sprintf('The icon name "%s" is too long.', $name));
+            if (100 < ($nameLength = \strlen($name))) {
+                throw new \InvalidArgumentException(\sprintf('The icon name "%s" is too long.', $name));
             }
             if ($curLength && ($maxLength < ($curLength + $nameLength + 1))) {
                 yield $curBatch;

src/Icons/tests/Integration/Command/ImportIconCommandTest.php

@@ -46,7 +46,7 @@ public function testCanImportIcon(): void
         $this->executeConsoleCommand('ux:icons:import uiw:dashboard')
             ->assertSuccessful()
             ->assertOutputContains('Icon set: uiw icons (License: MIT)')
-            ->assertOutputContains("Importing uiw:dashboard")
+            ->assertOutputContains('Importing uiw:dashboard')
         ;
 
         $this->assertFileExists($expectedFile);

src/Icons/tests/Unit/IconifyTest.php

@@ -298,7 +298,7 @@ public function testChunkThrowWithIconPrefixTooLong(): void
         $prefix = str_pad('p', 101, 'p');
         $name = 'icon';
 
-        $this->expectExceptionMessage(sprintf('The icon prefix "%s" is too long.', $prefix));
+        $this->expectExceptionMessage(\sprintf('The icon prefix "%s" is too long.', $prefix));
 
         // We need to iterate over the iterator to trigger the exception
         $result = iterator_to_array($iconify->chunk($prefix, [$name]));
@@ -311,7 +311,7 @@ public function testChunkThrowWithIconNameTooLong(): void
         $prefix = 'prefix';
         $name = str_pad('n', 101, 'n');
 
-        $this->expectExceptionMessage(sprintf('The icon name "%s" is too long.', $name));
+        $this->expectExceptionMessage(\sprintf('The icon name "%s" is too long.', $name));
 
         // We need to iterate over the iterator to trigger the exception
         $result = iterator_to_array($iconify->chunk($prefix, [$name]));