Fix LiveComponentMetadataFactoryTest testLivePropUnionType

Author: kevinmade

src/LiveComponent/src/Metadata/LiveComponentMetadataFactory.php

@@ -83,12 +83,13 @@ public function createPropMetadatas(\ReflectionClass $class): array
     public function createLivePropMetadata(string $className, string $propertyName, \ReflectionProperty $property, LiveProp $liveProp): LivePropMetadata|LegacyLivePropMetadata
     {
         $reflectionType = $property->getType();
-        if ($reflectionType instanceof \ReflectionUnionType || $reflectionType instanceof \ReflectionIntersectionType) {
-            return new LivePropMetadata($property->getName(), $liveProp, Type::mixed());
-        }
 
         // BC layer when "symfony/type-info" is not available
         if (!method_exists($this->propertyTypeExtractor, 'getType')) {
+            if ($reflectionType instanceof \ReflectionUnionType || $reflectionType instanceof \ReflectionIntersectionType) {
+                return new LegacyLivePropMetadata($property->getName(), $liveProp, 'mixed', true, $reflectionType->allowsNull(), null);
+            }
+
             $infoTypes = $this->propertyTypeExtractor->getTypes($className, $propertyName) ?? [];
 
             $collectionValueType = null;
@@ -122,6 +123,10 @@ public function createLivePropMetadata(string $className, string $propertyName,
                 $collectionValueType
             );
         } else {
+            if ($reflectionType instanceof \ReflectionUnionType || $reflectionType instanceof \ReflectionIntersectionType) {
+                return new LivePropMetadata($property->getName(), $liveProp, Type::mixed());
+            }
+
             $infoType = $this->propertyTypeExtractor->getType($className, $property->getName());
 
             if ($infoType instanceof CollectionType) {

src/LiveComponent/tests/Fixtures/Component/WithUnionType.php renamed to src/LiveComponent/tests/Fixtures/Component/WithUnionIntersectionType.php

@@ -14,12 +14,17 @@
 use Symfony\UX\LiveComponent\Attribute\AsLiveComponent;
 use Symfony\UX\LiveComponent\Attribute\LiveProp;
 use Symfony\UX\LiveComponent\DefaultActionTrait;
+use Symfony\UX\LiveComponent\Tests\Fixtures\Enum\IntEnum;
+use Symfony\UX\LiveComponent\Tests\Fixtures\Enum\ZeroIntEnum;
 
-#[AsLiveComponent('with_union_type')]
-final class WithUnionType
+#[AsLiveComponent('with_union_intersection_type')]
+final class WithUnionIntersectionType
 {
     use DefaultActionTrait;
 
     #[LiveProp]
     public int|float|null $unionProp = null;
+
+    #[LiveProp]
+    public IntEnum&ZeroIntEnum $intersectionProp;
 }

src/LiveComponent/tests/Functional/Metadata/LiveComponentMetadataFactoryTest.php

@@ -12,11 +12,10 @@
 namespace Symfony\UX\LiveComponent\Tests\Functional\Metadata;
 
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
-use Symfony\Component\TypeInfo\Type;
 use Symfony\UX\LiveComponent\Metadata\LiveComponentMetadataFactory;
 use Symfony\UX\LiveComponent\Metadata\UrlMapping;
 use Symfony\UX\LiveComponent\Tests\Fixtures\Component\ComponentWithUrlBoundProps;
-use Symfony\UX\LiveComponent\Tests\Fixtures\Component\WithUnionType;
+use Symfony\UX\LiveComponent\Tests\Fixtures\Component\WithUnionIntersectionType;
 
 class LiveComponentMetadataFactoryTest extends KernelTestCase
 {
@@ -50,14 +49,15 @@ public function testLivePropUnionType()
         /** @var LiveComponentMetadataFactory $metadataFactory */
         $metadataFactory = self::getContainer()->get('ux.live_component.metadata_factory');
 
-        $class = new \ReflectionClass(WithUnionType::class);
+        $class = new \ReflectionClass(WithUnionIntersectionType::class);
         $propsMetadata = $metadataFactory->createPropMetadatas($class);
 
         $propsMetadataByName = [];
         foreach ($propsMetadata as $propMetadata) {
             $propsMetadataByName[$propMetadata->getName()] = $propMetadata;
         }
 
-        $this->assertEquals(Type::mixed(), $propsMetadataByName['unionProp']->getType());
+        $this->assertEquals('mixed', (string)$propsMetadataByName['unionProp']->getType());
+        $this->assertEquals('mixed', (string)$propsMetadataByName['intersectionProp']->getType());
     }
 }