Skip to content

Commit e73ef11

Browse files
committed
Run E2E app in CI
1 parent 4ff8e80 commit e73ef11

File tree

8 files changed

+92
-25
lines changed

8 files changed

+92
-25
lines changed

.github/workflows/browser-tests.yml

Lines changed: 69 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,22 @@ on:
2020
- '.github/workflows/app-tests.yaml'
2121
- '.github/workflows/unit-tests.yaml'
2222

23+
concurrency:
24+
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
25+
cancel-in-progress: true
26+
2327
jobs:
24-
js:
28+
test:
2529
runs-on: ubuntu-latest
30+
strategy:
31+
fail-fast: false
32+
matrix:
33+
symfony: ['6.4.*', '7.3.*']
34+
env:
35+
SYMFONY_REQUIRE: '${{ matrix.symfony }}'
2636
steps:
2737
- uses: actions/checkout@v4
38+
2839
- run: npm i -g corepack && corepack enable
2940
- uses: actions/setup-node@v4
3041
with:
@@ -33,21 +44,68 @@ jobs:
3344
cache-dependency-path: |
3445
pnpm-lock.yaml
3546
package.json
36-
src/**/package.json
37-
- run: pnpm install --frozen-lockfile
3847
39-
- name: Install custom browsers
40-
run: node ./bin/get_browsers.mjs
48+
- name: Install root JS dependencies
49+
run: pnpm install --frozen-lockfile
50+
51+
- name: Install custom browsers
52+
run: node ./bin/get_browsers.mjs
53+
54+
- name: Install browsers with Playwright
55+
run: pnpm exec playwright install firefox ffmpeg
56+
57+
- uses: shivammathur/setup-php@v2
58+
with:
59+
php-version: 8.2
60+
tools: symfony-cli, flex
61+
62+
- name: Install root PHP dependencies
63+
uses: ramsey/composer-install@v3
64+
with:
65+
working-directory: ${{ github.workspace }}
66+
67+
- name: Build root packages
68+
run: php .github/build-packages.php
4169

42-
- name: Install browsers with Playwright
43-
run: pnpm exec playwright install firefox ffmpeg
70+
- name: Start Docker containers
71+
run: docker compose up -d --build
72+
working-directory: test_apps/e2e-app
4473

45-
# TODO: Install the E2E app + run webserver
46-
- run: pnpm run test:browser
74+
- name: Configure E2E app
75+
run: |
76+
echo 'APP_ENV=test' >> .env.local
77+
echo 'APP_DEBUG=0' >> .env.local
78+
working-directory: test_apps/e2e-app
79+
80+
- name: Install E2E PHP dependencies
81+
uses: ramsey/composer-install@v3
82+
with:
83+
working-directory: test_apps/e2e-app
84+
85+
- name: Prepare E2E app
86+
run: |
87+
symfony composer dump-env
88+
symfony console cache:warmup
89+
working-directory: test_apps/e2e-app
90+
91+
- name: Start E2E app
92+
run: symfony serve
93+
working-directory: test_apps/e2e-app
94+
95+
- name: Run browser tests
96+
run: pnpm run test:browser
97+
id: browser-tests
4798

4899
- uses: actions/upload-artifact@v4
49-
if: ${{ !cancelled() }}
100+
if: ${{ browser-tests.outcome == 'failure' }}
50101
with:
51-
name: playwright-report
102+
name: Playwright report
52103
path: .playwright-report/
53104
retention-days: 7
105+
106+
- uses: actions/upload-artifact@v4
107+
if: ${{ browser-tests.outcome == 'failure' }}
108+
with:
109+
name: Symfony logs
110+
path: test_apps/e2e-app/var/log/
111+
retention-days: 7

.github/workflows/code-quality.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,16 @@ jobs:
2424
runs-on: ubuntu-latest
2525
steps:
2626
- uses: actions/checkout@v4
27+
2728
- run: npm i -g corepack && corepack enable
2829
- uses: actions/setup-node@v4
2930
with:
3031
node-version-file: '.nvmrc'
3132
cache: 'pnpm'
32-
- run: pnpm install --frozen-lockfile
33+
34+
- name: Install root JS dependencies
35+
run: pnpm install --frozen-lockfile
36+
3337
- run: pnpm run ci
3438

3539
phpstan:

.github/workflows/dist-files-unbuilt.yaml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ jobs:
2121
runs-on: ubuntu-latest
2222
steps:
2323
- uses: actions/checkout@v4
24+
2425
- run: npm i -g corepack && corepack enable
2526
- uses: actions/setup-node@v4
2627
with:
@@ -29,7 +30,12 @@ jobs:
2930
cache-dependency-path: |
3031
pnpm-lock.yaml
3132
**/package.json
32-
- run: pnpm install --frozen-lockfile && pnpm run build
33+
34+
- name: Install root JS dependencies
35+
run: pnpm install --frozen-lockfile
36+
37+
- name: Build
38+
run: pnpm run build
3339

3440
- name: Check if JS dist files are current
3541
run: |

.github/workflows/release-on-npm.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ jobs:
3030
pnpm-lock.yaml
3131
package.json
3232
src/**/package.json
33-
- run: pnpm install --frozen-lockfile
33+
- name: Install root JS dependencies
34+
run: pnpm install --frozen-lockfile
3435

3536
- name: Update version of JS packages
3637
run: pnpm version ${{ env.VERSION }} --no-git-tag-version --workspaces --no-workspaces-update

.github/workflows/unit-tests.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ jobs:
145145
runs-on: ubuntu-latest
146146
steps:
147147
- uses: actions/checkout@v4
148+
148149
- run: npm i -g corepack && corepack enable
149150
- uses: actions/setup-node@v4
150151
with:
@@ -154,5 +155,8 @@ jobs:
154155
pnpm-lock.yaml
155156
package.json
156157
src/**/package.json
157-
- run: pnpm install --frozen-lockfile
158+
159+
- name: Install root JS dependencies
160+
run: pnpm install --frozen-lockfile
161+
158162
- run: pnpm run test:unit

bin/test_package.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,14 +101,15 @@ processWorkspace() {
101101
# Install each version of the library separately
102102
echo -e " - Install $library@$trimmed_version for $workspace\n"
103103
pnpm add "$library@$trimmed_version" --save-peer --filter "$workspace"
104+
pnpm run --filter "$workspace" build
104105

105106
runTestSuite
106107
fi
107108
done
108109
done
109110

110-
echo " -> Reverting version changes from $package_json_path"
111-
git checkout -- "$package_json_path" "$PROJECT_DIR/pnpm-lock.yaml"
111+
echo " -> Reverting changes"
112+
git checkout -- "$package_json_path" "$location/dist" "$PROJECT_DIR/pnpm-lock.yaml"
112113
else
113114
echo -e " -> No peerDependencies found with multiple versions defined\n"
114115
runTestSuite

playwright.config.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,6 @@ export default defineConfig({
2727
trace: 'retain-on-failure'
2828
},
2929

30-
//webServer: {
31-
// command: 'cd test_apps/e2e-app && symfony serve',
32-
// url: 'http://localhost:9876',
33-
// reuseExistingServer: !process.env.CI,
34-
// stderr: 'pipe',
35-
//},
36-
3730
projects: [
3831
{
3932
name: 'chrome-lowest',

test_apps/e2e-app/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ to ensure they work as expected for multiple Symfony versions and various browse
88
## Requirements
99

1010
- Symfony CLI
11-
- PHP 8.1 or higher
11+
- PHP 8.2 or higher
1212
- Docker and Docker Compose
1313
- Composer
1414

0 commit comments

Comments
 (0)