Skip to content

Commit f0c1bf5

Browse files
committed
fix post reviews
1 parent e76d201 commit f0c1bf5

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

src/Map/src/Bridge/Google/assets/dist/map_controller.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import AbstractMapController from '@symfony/ux-map';
33
import type { CircleDefinition, Icon, InfoWindowWithoutPositionDefinition, MarkerDefinition, Point, PolygonDefinition, PolylineDefinition, RectangleDefinition } from '@symfony/ux-map';
44
type MapOptions = Pick<google.maps.MapOptions, 'mapId' | 'gestureHandling' | 'backgroundColor' | 'disableDoubleClickZoom' | 'zoomControl' | 'zoomControlOptions' | 'mapTypeControl' | 'mapTypeControlOptions' | 'streetViewControl' | 'streetViewControlOptions' | 'fullscreenControl' | 'fullscreenControlOptions'>;
55
export default class extends AbstractMapController<MapOptions, google.maps.Map, google.maps.marker.AdvancedMarkerElementOptions, google.maps.marker.AdvancedMarkerElement, google.maps.InfoWindowOptions, google.maps.InfoWindow, google.maps.PolygonOptions, google.maps.Polygon, google.maps.PolylineOptions, google.maps.Polyline, google.maps.CircleOptions, google.maps.Circle, google.maps.RectangleOptions, google.maps.Rectangle> {
6-
protected doRemoveRectangle(rectangle: google.maps.Rectangle): void;
76
providerOptionsValue: Pick<LoaderOptions, 'apiKey' | 'id' | 'language' | 'region' | 'nonce' | 'retries' | 'url' | 'version' | 'libraries'>;
87
map: google.maps.Map;
98
parser: DOMParser;
@@ -35,6 +34,7 @@ export default class extends AbstractMapController<MapOptions, google.maps.Map,
3534
protected doCreateRectangle({ definition, }: {
3635
definition: RectangleDefinition<google.maps.RectangleOptions, google.maps.InfoWindowOptions>;
3736
}): google.maps.Rectangle;
37+
protected doRemoveRectangle(rectangle: google.maps.Rectangle): void;
3838
protected doCreateInfoWindow({ definition, element, }: {
3939
definition: InfoWindowWithoutPositionDefinition<google.maps.InfoWindowOptions>;
4040
element: google.maps.marker.AdvancedMarkerElement | google.maps.Polygon | google.maps.Polyline;

src/Map/src/Bridge/Google/assets/dist/map_controller.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,6 @@ default_1.values = {
133133
let _google;
134134
const parser = new DOMParser();
135135
class map_controller extends default_1 {
136-
doRemoveRectangle(rectangle) {
137-
throw new Error('Method not implemented.');
138-
}
139136
async connect() {
140137
if (!_google) {
141138
_google = { maps: {} };
@@ -279,6 +276,9 @@ class map_controller extends default_1 {
279276
}
280277
return rectangle;
281278
}
279+
doRemoveRectangle(rectangle) {
280+
rectangle.setMap(null);
281+
}
282282
doCreateInfoWindow({ definition, element, }) {
283283
const { headerContent, content, extra, rawOptions = {}, ...otherOptions } = definition;
284284
const infoWindow = new _google.maps.InfoWindow({

src/Map/src/Bridge/Google/assets/src/map_controller.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,6 @@ export default class extends AbstractMapController<
5757
google.maps.RectangleOptions,
5858
google.maps.Rectangle
5959
> {
60-
protected doRemoveRectangle(rectangle: google.maps.Rectangle): void {
61-
throw new Error('Method not implemented.');
62-
}
6360
declare providerOptionsValue: Pick<
6461
LoaderOptions,
6562
'apiKey' | 'id' | 'language' | 'region' | 'nonce' | 'retries' | 'url' | 'version' | 'libraries'
@@ -287,6 +284,11 @@ export default class extends AbstractMapController<
287284

288285
return rectangle;
289286
}
287+
288+
protected doRemoveRectangle(rectangle: google.maps.Rectangle): void {
289+
rectangle.setMap(null);
290+
}
291+
290292
protected doCreateInfoWindow({
291293
definition,
292294
element,

0 commit comments

Comments
 (0)