Destroy the chart on disconnect

Author: f-schnabel

src/Chartjs/assets/dist/controller.d.ts

@@ -5,7 +5,8 @@ export default class extends Controller {
         view: ObjectConstructor;
     };
     private chart;
-    initialize(): void;
+    connect(): void;
+    disconnect(): void;
     viewValueChanged(): void;
     private dispatchEvent;
 }

src/Chartjs/assets/dist/controller.js

@@ -10,7 +10,7 @@ class default_1 extends Controller {
         super(...arguments);
         this.chart = null;
     }
-    initialize() {
+    connect() {
         if (!isChartInitialized) {
             isChartInitialized = true;
             this.dispatchEvent('init', {
@@ -35,6 +35,13 @@ class default_1 extends Controller {
         this.chart = new Chart(canvasContext, payload);
         this.dispatchEvent('connect', { chart: this.chart });
     }
+    disconnect() {
+        if (this.chart) {
+            this.chart.destroy();
+            this.chart = null;
+        }
+        this.dispatchEvent('disconnect', { chart: this.chart });
+    }
     viewValueChanged() {
         if (this.chart) {
             const viewValue = { data: this.viewValue.data, options: this.viewValue.options };

src/Chartjs/assets/src/controller.ts

@@ -28,7 +28,7 @@ export default class extends Controller {
 
     private chart: Chart | null = null;
 
-    initialize() {
+    connect() {
         if (!isChartInitialized) {
             isChartInitialized = true;
             this.dispatchEvent('init', {
@@ -59,6 +59,15 @@ export default class extends Controller {
         this.dispatchEvent('connect', { chart: this.chart });
     }
 
+    disconnect() {
+        if (this.chart) {
+            this.chart.destroy();
+            this.chart = null;
+        }
+
+        this.dispatchEvent('disconnect', { chart: this.chart });
+    }
+
     /**
      * If the underlying data or options change, let's update the chart!
      */