add the new ProgressIndicator #2366
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
requested changes
Nov 11, 2024
carsonbot
added
Status: Needs Work
Co-authored-by: Hugo Alliaume <[email protected]>
carsonbot
added
Status: Needs Review
|
I imagine this might be fun, but this may not be the best place to do it since this command runs in ... less than 200ms. 😅 I tried it out but couldn't even catch the beginning of any animation here. I'll close this for now, but thank you for the effort / creativity! Would welcome other similar PR with joy :) progressindicator.mov |
|
Understood. In the process, though, I found an error in the blog post: https://symfony.com/blog/new-in-symfony-7-2-console-finished-indicator#comment-25571 so it was a worthwhile exercise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following https://symfony.com/blog/new-in-symfony-7-2-console-finished-indicator, mostly to see it in action.