[TwigComponent] Fix ComponentAttributes rendering when using StimulusAttributes as default attributes
#2757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Bug
Kocal
commented
May 20, 2025
Comment on lines
154
to
155
| 'data-foo-some-array-value' => '["a","b"]', | ||
| 'data-foo-some-array-with-keys-value' => '{"key1":"value1","key2":"value2"}' |
There was a problem hiding this comment.
Without the fix:
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
'data-controller' => 'foo live'
'data-live-data-value' => '{}'
'data-foo-name-value' => 'ryan'
- 'data-foo-some-array-value' => '["a","b"]'
- 'data-foo-some-array-with-keys-value' => '{"key1":"value1","key2":"value2"}'
+ 'data-foo-some-array-value' => '["a","b"]'
+ 'data-foo-some-array-with-keys-value' => '{"key1":"value1","key2":"value2"}'
)
Kocal
commented
May 20, 2025
| 'data-foo-some-array-value' => '["a","b"]', | ||
| 'data-foo-some-array-with-keys-value' => '{"key1":"value1","key2":"value2"}' | ||
| ], $attributes->all()); | ||
| $this->assertSame(' data-controller="foo live" data-foo-name-value="ryan" data-foo-some-array-value="["a","b"]" data-foo-some-array-with-keys-value="{"key1":"value1","key2":"value2"}" class="foo" data-live-data-value="{}"', (string) $attributes); |
There was a problem hiding this comment.
Without the fix:
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-' data-controller="foo live" data-foo-name-value="ryan" data-foo-some-array-value="["a","b"]" data-foo-some-array-with-keys-value="{"key1":"value1","key2":"value2"}" class="foo" data-live-data-value="{}"'
+' data-controller="foo live" data-foo-name-value="ryan" data-foo-some-array-value="["a","b"]" data-foo-some-array-with-keys-value="{"key1":"value1","key2":"value2"}" class="foo" data-live-data-value="{}"'
…lusAttributes` as default attributes
Kocal
force-pushed
the
fix-2756-twig-comp-stimulus-escape
branch
from
ee1aac2 to
8ed98d6
Compare
nicolas-grekas
approved these changes
May 20, 2025
carsonbot
added
Status: Reviewed
kbond
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed the case where we can inject
StimulusAttributeswhen usingattributes.defaults(), as documented in https://symfony.com/bundles/ux-twig-component/current/index.html#component-attributesIt looks like our tests weren't solid enough, since we asserted on
all()instead of the rendered string.