Refactor "test_package.sh" to its original purpose, add multiples checks for packages definition #3090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
Kocal
force-pushed
the
refactor-pkg-assets-testing
branch
5 times, most recently
from
1ce429a to
d153745
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the test scripts to separate unit testing from browser testing by introducing a dedicated unit_test_package.sh script and replacing browser test commands with direct Playwright invocations. Additionally, it adds validation checks for package definitions in composer.json and package.json files.
- Updated test commands across all package.json files to use dedicated unit test script
- Replaced browser test commands with direct Playwright invocations
- Added comprehensive package validation workflow with multiple checks for composer.json and package.json files
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Multiple assets/package.json files | Updated test:unit commands to use unit_test_package.sh and replaced browser test commands with direct playwright test invocations |
| src/Toolkit/composer.json | Added keywords, removed conflict section, and added minimum-stability requirement |
| src/Swup/composer.json | Added php version requirement |
| .github/workflows/code-quality.yaml | Added comprehensive package validation workflow with multiple checks for consistency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Kocal
force-pushed
the
refactor-pkg-assets-testing
branch
2 times, most recently
from
10cf25c to
393bf25
Compare
…cks for packages definition
Kocal
force-pushed
the
refactor-pkg-assets-testing
branch
from
393bf25 to
4949e62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the minor changes from #3086