[Autocomplete] Untranslated no_results label when options_as_html is set
#3148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Autocomplete
Bug
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
|||||||||
…erge (such as `no_results`) for `options_as_html` inputs
maxperei
force-pushed
the
fix/autocomplete-options-as-html-no-results-untranslated
branch
from
76664dd to
dba3f5f
Compare
|
Thank you @maxperei. |
maxperei
deleted the
fix/autocomplete-options-as-html-no-results-untranslated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during
createAutocompleteWithHtmlContents()it seems that acommonConfigis overridden by a new one but some nested properties are lost during the#mergeConfigs()and especiallyno_resultsthat fallbacks to the untranslated tom-select default one