Add type to final/internal public/protected properties

Author: nicolas-grekas

Constraints/Email.php

@@ -31,21 +31,16 @@ class Email extends Constraint
 
     public const INVALID_FORMAT_ERROR = 'bd79c0ab-ddba-46cc-a703-a7a4b08de310';
 
-    protected static $errorNames = [
-        self::INVALID_FORMAT_ERROR => 'STRICT_CHECK_FAILED_ERROR',
-    ];
-
-    /**
-     * @var string[]
-     *
-     * @internal
-     */
-    public static $validationModes = [
+    public const VALIDATION_MODES = [
         self::VALIDATION_MODE_HTML5,
         self::VALIDATION_MODE_STRICT,
         self::VALIDATION_MODE_LOOSE,
     ];
 
+    protected static $errorNames = [
+        self::INVALID_FORMAT_ERROR => 'STRICT_CHECK_FAILED_ERROR',
+    ];
+
     public $message = 'This value is not a valid email address.';
     public $mode;
     public $normalizer;
@@ -58,7 +53,7 @@ public function __construct(
         array $groups = null,
         mixed $payload = null
     ) {
-        if (\is_array($options) && \array_key_exists('mode', $options) && !\in_array($options['mode'], self::$validationModes, true)) {
+        if (\is_array($options) && \array_key_exists('mode', $options) && !\in_array($options['mode'], self::VALIDATION_MODES, true)) {
             throw new InvalidArgumentException('The "mode" parameter value is not valid.');
         }
 

Constraints/EmailValidator.php

@@ -36,7 +36,7 @@ class EmailValidator extends ConstraintValidator
 
     public function __construct(string $defaultMode = Email::VALIDATION_MODE_LOOSE)
     {
-        if (!\in_array($defaultMode, Email::$validationModes, true)) {
+        if (!\in_array($defaultMode, Email::VALIDATION_MODES, true)) {
             throw new \InvalidArgumentException('The "defaultMode" parameter value is not valid.');
         }
 
@@ -73,7 +73,7 @@ public function validate(mixed $value, Constraint $constraint)
             $constraint->mode = $this->defaultMode;
         }
 
-        if (!\in_array($constraint->mode, Email::$validationModes, true)) {
+        if (!\in_array($constraint->mode, Email::VALIDATION_MODES, true)) {
             throw new \InvalidArgumentException(sprintf('The "%s::$mode" parameter value is not valid.', get_debug_type($constraint)));
         }