Make trans + %count% parameter resolve plurals

Author: nicolas-grekas

Context/ExecutionContext.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\Validator\Context;
 
+use Symfony\Component\Translation\TranslatorInterface as LegacyTranslatorInterface;
 use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\ConstraintViolation;
 use Symfony\Component\Validator\ConstraintViolationList;
@@ -140,8 +141,11 @@ class ExecutionContext implements ExecutionContextInterface
      * @internal Called by {@link ExecutionContextFactory}. Should not be used
      *           in user code.
      */
-    public function __construct(ValidatorInterface $validator, $root, TranslatorInterface $translator, string $translationDomain = null)
+    public function __construct(ValidatorInterface $validator, $root, $translator, string $translationDomain = null)
     {
+        if (!$translator instanceof LegacyTranslatorInterface && !$translator instanceof TranslatorInterface) {
+            throw new \TypeError(sprintf('Argument 3 passed to %s() must be an instance of %s, %s given.', __METHOD__, TranslatorInterface::class, \is_object($translator) ? \get_class($translator) : \gettype($translator)));
+        }
         $this->validator = $validator;
         $this->root = $root;
         $this->translator = $translator;

Context/ExecutionContextFactory.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\Validator\Context;
 
+use Symfony\Component\Translation\TranslatorInterface as LegacyTranslatorInterface;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
 use Symfony\Contracts\Translation\TranslatorInterface;
 
@@ -34,8 +35,12 @@ class ExecutionContextFactory implements ExecutionContextFactoryInterface
      *                                               use for translating
      *                                               violation messages
      */
-    public function __construct(TranslatorInterface $translator, string $translationDomain = null)
+    public function __construct($translator, string $translationDomain = null)
     {
+        if (!$translator instanceof LegacyTranslatorInterface && !$translator instanceof TranslatorInterface) {
+            throw new \TypeError(sprintf('Argument 1 passed to %s() must be an instance of %s, %s given.', __METHOD__, TranslatorInterface::class, \is_object($translator) ? \get_class($translator) : \gettype($translator)));
+        }
+
         $this->translator = $translator;
         $this->translationDomain = $translationDomain;
     }

Util/LegacyTranslatorProxy.php

@@ -11,18 +11,14 @@
 
 namespace Symfony\Component\Validator\Util;
 
-use Symfony\Component\Translation\LegacyTranslatorTrait;
 use Symfony\Component\Translation\TranslatorInterface as LegacyTranslatorInterface;
 use Symfony\Contracts\Translation\TranslatorInterface;
 
 /**
  * @internal to be removed in Symfony 5.0.
  */
-class LegacyTranslatorProxy implements LegacyTranslatorInterface
+class LegacyTranslatorProxy implements LegacyTranslatorInterface, TranslatorInterface
 {
-    use LegacyTranslatorTrait {
-        transChoice as private doTransChoice;
-    }
     private $translator;
 
     public function __construct(TranslatorInterface $translator)
@@ -64,10 +60,6 @@ public function trans($id, array $parameters = array(), $domain = null, $locale
      */
     public function transChoice($id, $number, array $parameters = array(), $domain = null, $locale = null)
     {
-        if ($this->translator instanceof LegacyTranslatorInterface) {
-            return $this->translator->transChoice($id, $number, $parameters, $domain, $locale);
-        }
-
-        $this->doTransChoice($id, $number, $parameters, $domain, $locale);
+        return $this->translator->trans($id, array('%count%' => $number) + $parameters, $domain, $locale);
     }
 }

Violation/ConstraintViolationBuilder.php

@@ -44,8 +44,14 @@ class ConstraintViolationBuilder implements ConstraintViolationBuilderInterface
      */
     private $cause;
 
-    public function __construct(ConstraintViolationList $violations, Constraint $constraint, $message, array $parameters, $root, $propertyPath, $invalidValue, TranslatorInterface $translator, $translationDomain = null)
+    /**
+     * @param TranslatorInterface $translator
+     */
+    public function __construct(ConstraintViolationList $violations, Constraint $constraint, $message, array $parameters, $root, $propertyPath, $invalidValue, $translator, $translationDomain = null)
     {
+        if (!$translator instanceof LegacyTranslatorInterface && !$translator instanceof TranslatorInterface) {
+            throw new \TypeError(sprintf('Argument 8 passed to %s() must be an instance of %s, %s given.', __METHOD__, TranslatorInterface::class, \is_object($translator) ? \get_class($translator) : \gettype($translator)));
+        }
         $this->violations = $violations;
         $this->message = $message;
         $this->parameters = $parameters;
@@ -142,12 +148,18 @@ public function setCause($cause)
      */
     public function addViolation()
     {
-        if (null === $this->plural || !$this->translator instanceof LegacyTranslatorInterface) {
+        if (null === $this->plural) {
             $translatedMessage = $this->translator->trans(
                 $this->message,
                 $this->parameters,
                 $this->translationDomain
             );
+        } elseif ($this->translator instanceof TranslatorInterface) {
+            $translatedMessage = $this->translator->trans(
+                $this->message,
+                array('%count%' => $this->plural) + $this->parameters,
+                $this->translationDomain
+            );
         } else {
             try {
                 $translatedMessage = $this->translator->transChoice(