Add return types to internal|final|private methods

Author: nicolas-grekas

Constraint.php

@@ -286,11 +286,9 @@ public function getTargets()
     /**
      * Optimizes the serialized value to minimize storage space.
      *
-     * @return array The properties to serialize
-     *
      * @internal
      */
-    public function __sleep()
+    public function __sleep(): array
     {
         // Initialize "groups" option if it is not set
         $this->groups;

Constraints/DateValidator.php

@@ -26,15 +26,9 @@ class DateValidator extends ConstraintValidator
     /**
      * Checks whether a date is valid.
      *
-     * @param int $year  The year
-     * @param int $month The month
-     * @param int $day   The day
-     *
-     * @return bool Whether the date is valid
-     *
      * @internal
      */
-    public static function checkDate($year, $month, $day)
+    public static function checkDate(int $year, int $month, int $day): bool
     {
         return checkdate($month, $day, $year);
     }

Constraints/TimeValidator.php

@@ -26,15 +26,9 @@ class TimeValidator extends ConstraintValidator
     /**
      * Checks whether a time is valid.
      *
-     * @param int $hour   The hour
-     * @param int $minute The minute
-     * @param int $second The second
-     *
-     * @return bool Whether the time is valid
-     *
      * @internal
      */
-    public static function checkTime($hour, $minute, $second)
+    public static function checkTime(int $hour, int $minute, float $second): bool
     {
         return $hour >= 0 && $hour < 24 && $minute >= 0 && $minute < 60 && $second >= 0 && $second < 60;
     }

Tests/Constraints/RegexValidatorTest.php

@@ -72,7 +72,7 @@ public function getValidValues()
             ['090909'],
             [90909],
             [new class() {
-                public function __toString()
+                public function __toString(): string
                 {
                     return '090909';
                 }
@@ -116,7 +116,7 @@ public function getInvalidValues()
             ['abcd'],
             ['090foo'],
             [new class() {
-                public function __toString()
+                public function __toString(): string
                 {
                     return 'abcd';
                 }