bug #50524 Fix Doctrine deprecations (nicolas-grekas)

This PR was merged into the 5.4 branch.

Discussion
----------

Fix Doctrine deprecations

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #50481
| License       | MIT
| Doc PR        | -

Commits
-------

6a3a4d7fb7 Fix Doctrine deprecations

Author: nicolas-grekas

Mapping/ClassMetadata.php

@@ -356,16 +356,17 @@ public function mergeConstraints(self $source)
                     $constraint->addImplicitGroupName($this->getDefaultGroup());
                 }
 
-                $this->addPropertyMetadata($member);
-
                 if ($member instanceof MemberMetadata && !$member->isPrivate($this->name)) {
                     $property = $member->getPropertyName();
+                    $this->members[$property] = [$member];
 
-                    if ($member instanceof PropertyMetadata && !isset($this->properties[$property])) {
+                    if ($member instanceof PropertyMetadata) {
                         $this->properties[$property] = $member;
-                    } elseif ($member instanceof GetterMetadata && !isset($this->getters[$property])) {
+                    } elseif ($member instanceof GetterMetadata) {
                         $this->getters[$property] = $member;
                     }
+                } else {
+                    $this->addPropertyMetadata($member);
                 }
             }
         }

Mapping/Loader/AnnotationLoader.php

@@ -95,29 +95,51 @@ public function loadClassMetadata(ClassMetadata $metadata)
      */
     private function getAnnotations(object $reflection): iterable
     {
+        $dedup = [];
+
         if (\PHP_VERSION_ID >= 80000) {
             foreach ($reflection->getAttributes(GroupSequence::class) as $attribute) {
+                $dedup[] = $attribute->newInstance();
                 yield $attribute->newInstance();
             }
             foreach ($reflection->getAttributes(GroupSequenceProvider::class) as $attribute) {
+                $dedup[] = $attribute->newInstance();
                 yield $attribute->newInstance();
             }
             foreach ($reflection->getAttributes(Constraint::class, \ReflectionAttribute::IS_INSTANCEOF) as $attribute) {
+                $dedup[] = $attribute->newInstance();
                 yield $attribute->newInstance();
             }
         }
         if (!$this->reader) {
             return;
         }
 
+        $annotations = [];
+
         if ($reflection instanceof \ReflectionClass) {
-            yield from $this->reader->getClassAnnotations($reflection);
+            $annotations = $this->reader->getClassAnnotations($reflection);
         }
         if ($reflection instanceof \ReflectionMethod) {
-            yield from $this->reader->getMethodAnnotations($reflection);
+            $annotations = $this->reader->getMethodAnnotations($reflection);
         }
         if ($reflection instanceof \ReflectionProperty) {
-            yield from $this->reader->getPropertyAnnotations($reflection);
+            $annotations = $this->reader->getPropertyAnnotations($reflection);
+        }
+
+        foreach ($dedup as $annotation) {
+            if ($annotation instanceof Constraint) {
+                $annotation->groups; // trigger initialization of the "groups" property
+            }
+        }
+
+        foreach ($annotations as $annotation) {
+            if ($annotation instanceof Constraint) {
+                $annotation->groups; // trigger initialization of the "groups" property
+            }
+            if (!\in_array($annotation, $dedup, false)) {
+                yield $annotation;
+            }
         }
     }
 }