Never rely on dynamic properties

Author: nicolas-grekas

CHANGELOG.md

@@ -96,7 +96,7 @@ CHANGELOG
 3.2.0
 -----
 
- * deprecated `Tests\Constraints\AbstractContraintValidatorTest` in favor of `Test\ConstraintValidatorTestCase`
+ * deprecated `Tests\Constraints\AbstractConstraintValidatorTest` in favor of `Test\ConstraintValidatorTestCase`
  * added support for PHP constants in YAML configuration files
 
 3.1.0

Constraint.php

@@ -25,8 +25,6 @@
  *
  * Constraint instances are immutable and serializable.
  *
- * @property string[] $groups The groups that the constraint belongs to
- *
  * @author Bernhard Schussek <[email protected]>
  */
 abstract class Constraint
@@ -58,6 +56,13 @@ abstract class Constraint
      */
     public $payload;
 
+    /**
+     * The groups that the constraint belongs to.
+     *
+     * @var string[]
+     */
+    public $groups;
+
     /**
      * Returns the name of the given error code.
      *
@@ -105,14 +110,13 @@ public static function getErrorName($errorCode)
      */
     public function __construct($options = null)
     {
+        unset($this->groups); // enable lazy initialization
+
         $defaultOption = $this->getDefaultOption();
         $invalidOptions = [];
         $missingOptions = array_flip((array) $this->getRequiredOptions());
         $knownOptions = get_class_vars(static::class);
 
-        // The "groups" option is added to the object lazily
-        $knownOptions['groups'] = true;
-
         if (\is_array($options) && isset($options['value']) && !property_exists($this, 'value')) {
             if (null === $defaultOption) {
                 throw new ConstraintDefinitionException(sprintf('No default option is configured for constraint "%s".', static::class));

Constraints/Composite.php

@@ -79,7 +79,7 @@ public function __construct($options = null)
             }
         }
 
-        if (!property_exists($this, 'groups')) {
+        if (!isset(((array) $this)['groups'])) {
             $mergedGroups = [];
 
             foreach ($nestedConstraints as $constraint) {
@@ -96,7 +96,7 @@ public function __construct($options = null)
         }
 
         foreach ($nestedConstraints as $constraint) {
-            if (property_exists($constraint, 'groups')) {
+            if (isset(((array) $constraint)['groups'])) {
                 $excessGroups = array_diff($constraint->groups, $this->groups);
 
                 if (\count($excessGroups) > 0) {
@@ -141,7 +141,7 @@ abstract protected function getCompositeOption();
      *
      * @return Constraint[]
      */
-    public function getNestedContraints()
+    public function getNestedConstraints()
     {
         /* @var Constraint[] $nestedConstraints */
         return $this->{$this->getCompositeOption()};

Mapping/ClassMetadata.php

@@ -490,8 +490,8 @@ private function checkConstraint(Constraint $constraint)
         }
 
         if ($constraint instanceof Composite) {
-            foreach ($constraint->getNestedContraints() as $nestedContraint) {
-                $this->checkConstraint($nestedContraint);
+            foreach ($constraint->getNestedConstraints() as $nestedConstraint) {
+                $this->checkConstraint($nestedConstraint);
             }
         }
     }

Mapping/MemberMetadata.php

@@ -188,8 +188,8 @@ private function checkConstraint(Constraint $constraint)
         }
 
         if ($constraint instanceof Composite) {
-            foreach ($constraint->getNestedContraints() as $nestedContraint) {
-                $this->checkConstraint($nestedContraint);
+            foreach ($constraint->getNestedConstraints() as $nestedConstraint) {
+                $this->checkConstraint($nestedConstraint);
             }
         }
     }