Dont call sprintf() when no placeholders are used

nicolas-grekas · nicolas-grekas · commit 439675af81e6 · 2017-04-04T20:32:29.000+02:00
diff --git a/Validator.php b/Validator.php
@@ -151,7 +151,7 @@ public function validatePropertyValue($containingValue, $property, $value, $grou
                 ? '"'.$containingValue.'"'
                 : 'the value of type '.gettype($containingValue);
 
-            throw new ValidatorException(sprintf('The metadata for '.$valueAsString.' does not support properties.'));
+            throw new ValidatorException(sprintf('The metadata for %s does not support properties.', $valueAsString));
         }
 
         // If $containingValue is passed as class name, take $value as root

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ public function validatePropertyValue($containingValue, $property, $value, $grou`
`151`	`151`	`? '"'.$containingValue.'"'`
`152`	`152`	`: 'the value of type '.gettype($containingValue);`
`153`	`153`
`154`		`- throw new ValidatorException(sprintf('The metadata for '.$valueAsString.' does not support properties.'));`
	`154`	`+ throw new ValidatorException(sprintf('The metadata for %s does not support properties.', $valueAsString));`
`155`	`155`	`}`
`156`	`156`
`157`	`157`	`// If $containingValue is passed as class name, take $value as root`