fix merge

Author: nicolas-grekas

Tests/ConstraintViolationTest.php

@@ -108,4 +108,66 @@ public function testToStringOmitsEmptyCodes()
 
         $this->assertSame($expected, (string) $violation);
     }
+
+    public function testMessageCanBeStringableObject()
+    {
+        $message = new ToString();
+        $violation = new ConstraintViolation(
+            $message,
+            (string) $message,
+            [],
+            'Root',
+            'property.path',
+            null
+        );
+
+        $expected = <<<'EOF'
+Root.property.path:
+    toString
+EOF;
+        $this->assertSame($expected, (string) $violation);
+        $this->assertSame((string) $message, $violation->getMessage());
+    }
+
+    public function testMessageCannotBeArray()
+    {
+        $this->expectException(\TypeError::class);
+        $violation = new ConstraintViolation(
+            ['cannot be an array'],
+            '',
+            [],
+            'Root',
+            'property.path',
+            null
+        );
+    }
+
+    public function testMessageObjectMustBeStringable()
+    {
+        $this->expectException(\TypeError::class);
+        $violation = new ConstraintViolation(
+            new CustomArrayObject(),
+            '',
+            [],
+            'Root',
+            'property.path',
+            null
+        );
+    }
+
+    public function testNonStringCode()
+    {
+        $violation = new ConstraintViolation(
+            '42 cannot be used here',
+            'this is the message template',
+            [],
+            ['some_value' => 42],
+            'some_value',
+            null,
+            null,
+            42
+        );
+
+        self::assertSame(42, $violation->getCode());
+    }
 }

Tests/Fixtures/CustomArrayObject.php

@@ -24,7 +24,7 @@ public function __construct(array $array = null)
         $this->array = $array ?: [];
     }
 
-    public function offsetExists($offset)
+    public function offsetExists($offset): bool
     {
         return \array_key_exists($offset, $this->array);
     }
@@ -48,12 +48,12 @@ public function offsetUnset($offset)
         unset($this->array[$offset]);
     }
 
-    public function getIterator()
+    public function getIterator(): \Traversable
     {
         return new \ArrayIterator($this->array);
     }
 
-    public function count()
+    public function count(): int
     {
         return \count($this->array);
     }
@@ -63,7 +63,7 @@ public function __serialize(): array
         return $this->array;
     }
 
-    public function serialize()
+    public function serialize(): string
     {
         return serialize($this->__serialize());
     }

Tests/Fixtures/ToString.php

@@ -15,7 +15,7 @@ class ToString
 {
     public $data;
 
-    public function __toString()
+    public function __toString(): string
     {
         return 'toString';
     }