Fix some \Throwable support remaining issues

fancyweb · nicolas-grekas · commit 56be252ae6ac · 2019-11-12T18:18:47.000+01:00
diff --git a/DataCollector/ValidatorDataCollector.php b/DataCollector/ValidatorDataCollector.php
@@ -39,8 +39,10 @@ public function __construct(TraceableValidator $validator)
 
     /**
      * {@inheritdoc}
+     *
+     * @param \Throwable|null $exception
      */
-    public function collect(Request $request, Response $response, \Exception $exception = null)
+    public function collect(Request $request, Response $response/*, \Throwable $exception = null*/)
     {
         // Everything is collected once, on kernel terminate.
     }
diff --git a/composer.json b/composer.json
@@ -24,8 +24,7 @@
     "require-dev": {
         "symfony/http-client": "^4.3|^5.0",
         "symfony/http-foundation": "^4.1|^5.0",
-        "symfony/http-kernel": "^3.4|^4.0",
-        "symfony/var-dumper": "^3.4|^4.0|^5.0",
+        "symfony/http-kernel": "^4.4",
         "symfony/intl": "^4.3|^5.0",
         "symfony/yaml": "^3.4|^4.0|^5.0",
         "symfony/config": "^3.4|^4.0|^5.0",
@@ -43,7 +42,7 @@
         "doctrine/lexer": "<1.0.2",
         "phpunit/phpunit": "<4.8.35|<5.4.3,>=5.0",
         "symfony/dependency-injection": "<3.4",
-        "symfony/http-kernel": "<3.4",
+        "symfony/http-kernel": "<4.4",
         "symfony/intl": "<4.3",
         "symfony/translation": ">=5.0",
         "symfony/yaml": "<3.4"

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,10 @@ public function __construct(TraceableValidator $validator)`
`39`	`39`
`40`	`40`	`/**`
`41`	`41`	`* {@inheritdoc}`
	`42`	`+ *`
	`43`	`+ * @param \Throwable\|null $exception`
`42`	`44`	`*/`
`43`		`- public function collect(Request $request, Response $response, \Exception $exception = null)`
	`45`	`+ public function collect(Request $request, Response $response/, \Throwable $exception = null/)`
`44`	`46`	`{`
`45`	`47`	`// Everything is collected once, on kernel terminate.`
`46`	`48`	`}`