Skip to content

Commit 5b15337

Browse files
minor #61103 Fix various bool-type coercions (Girgias)
This PR was squashed before being merged into the 6.4 branch. Discussion ---------- Fix various bool-type coercions | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md --> | Issues | | License | MIT This is cherry-picking some of the commits from #60890 which are basically bugs. Not sure what the commit naming policy is so do let me know if you want me to manually rebase and rename commits following some guidelines. Commits ------- b3d30e3b60e Fix various bool-type coercions
2 parents 8d5f378 + d5cbc69 commit 5b15337

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Tests/Constraints/IsbnValidatorTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ public static function getInvalidIsbn()
121121

122122
public function testNullIsValid()
123123
{
124-
$constraint = new Isbn(true);
124+
$constraint = new Isbn();
125125

126126
$this->validator->validate(null, $constraint);
127127

@@ -130,7 +130,7 @@ public function testNullIsValid()
130130

131131
public function testEmptyStringIsValid()
132132
{
133-
$constraint = new Isbn(true);
133+
$constraint = new Isbn();
134134

135135
$this->validator->validate('', $constraint);
136136

@@ -140,7 +140,7 @@ public function testEmptyStringIsValid()
140140
public function testExpectsStringCompatibleType()
141141
{
142142
$this->expectException(UnexpectedValueException::class);
143-
$constraint = new Isbn(true);
143+
$constraint = new Isbn();
144144

145145
$this->validator->validate(new \stdClass(), $constraint);
146146
}

0 commit comments

Comments
 (0)