Merge branch '3.4' into 4.4

* 3.4:
  [PropertyAccess] fix tests
  [WebProfilerBundle] fix test
  remove assertions that can never be reached
  [PropertyAccess] Improve message of unitialized property in php 7.4
  [HttpFoundation] Fixed session migration with custom cookie lifetime
  [Serializer] Remove unused variable
  Allow URL-encoded special characters in basic auth part of URLs
  [Serializer] Fix unitialized properties (from PHP 7.4.2) when serializing context for the cache key
  [Validator] Add missing Ukrainian and Russian translations
  No need to reconnect the bags to the session
  Support for Content Security Policy style-src-elem and script-src-elem in WebProfiler
  [PropertyInfo][ReflectionExtractor] Check the array mutator prefixes last when the property is singular

Author: nicolas-grekas

Constraints/UrlValidator.php

@@ -24,7 +24,7 @@ class UrlValidator extends ConstraintValidator
 {
     const PATTERN = '~^
             (%s)://                                 # protocol
-            (([\_\.\pL\pN-]+:)?([\_\.\pL\pN-]+)@)?  # basic auth
+            (((?:[\_\.\pL\pN-]|%%[0-9A-Fa-f]{2})+:)?((?:[\_\.\pL\pN-]|%%[0-9A-Fa-f]{2})+)@)?  # basic auth
             (
                 ([\pL\pN\pS\-\_\.])+(\.?([\pL\pN]|xn\-\-[\pL\pN-]+)+\.?) # a domain name
                     |                                                 # or

Resources/translations/validators.ru.xlf

@@ -370,6 +370,18 @@
                 <source>This value is not a valid hostname.</source>
                 <target>Значение не является корректным именем хоста.</target>
             </trans-unit>
+            <trans-unit id="96">
+                <source>The number of elements in this collection should be a multiple of {{ compared_value }}.</source>
+                <target>Количество элементов в этой коллекции должно быть кратным {{ compared_value }}.</target>
+            </trans-unit>
+            <trans-unit id="97">
+                <source>This value should satisfy at least one of the following constraints:</source>
+                <target>Значение должно удовлетворять как минимум одному из следующих ограничений:</target>
+            </trans-unit>
+            <trans-unit id="98">
+                <source>Each element of this collection should satisfy its own set of constraints.</source>
+                <target>Каждый элемент этой коллекции должен удовлетворять своему собственному набору ограничений.</target>
+            </trans-unit>
         </body>
     </file>
 </xliff>

Resources/translations/validators.uk.xlf

@@ -366,6 +366,22 @@
                 <source>This value should be between {{ min }} and {{ max }}.</source>
                 <target>Значення має бути між {{ min }} та {{ max }}.</target>
             </trans-unit>
+            <trans-unit id="95">
+                <source>This value is not a valid hostname.</source>
+                <target>Значення не є дійсним іменем хоста.</target>
+            </trans-unit>
+            <trans-unit id="96">
+                <source>The number of elements in this collection should be a multiple of {{ compared_value }}.</source>
+                <target>Кількість елементів у цій колекції повинна бути кратною {{ compared_value }}.</target>
+            </trans-unit>
+            <trans-unit id="97">
+                <source>This value should satisfy at least one of the following constraints:</source>
+                <target>Значення повинно задовольняти хоча б одному з наступних обмежень:</target>
+            </trans-unit>
+            <trans-unit id="98">
+                <source>Each element of this collection should satisfy its own set of constraints.</source>
+                <target>Кожен елемент цієї колекції повинен задовольняти власному набору обмежень.</target>
+            </trans-unit>
         </body>
     </file>
 </xliff>

Tests/Constraints/UrlValidatorTest.php

@@ -157,6 +157,8 @@ public function getValidUrls()
             ['http://user.name:[email protected]'],
             ['http://[email protected]'],
             ['http://[email protected]'],
+            ['http://u%24er:[email protected]'],
+            ['http://user:pa%24%[email protected]'],
             ['http://symfony.com?'],
             ['http://symfony.com?query=1'],
             ['http://symfony.com/?query=1'],
@@ -255,6 +257,8 @@ public function getInvalidUrls()
             ['http://:password@@symfony.com'],
             ['http://username:passwordsymfony.com'],
             ['http://usern@me:[email protected]'],
+            ['http://nota%hex:[email protected]'],
+            ['http://username:nota%[email protected]'],
             ['http://example.com/exploit.html?<script>alert(1);</script>'],
             ['http://example.com/exploit.html?hel lo'],
             ['http://example.com/exploit.html?not_a%hex'],