replace assertEmpty() with stricter assertions

Author: xabbuh

Test/CompoundConstraintTestCase.php

@@ -102,7 +102,8 @@ protected function getConstraints(array $options): array
             next($expectedViolations);
         }
 
-        $this->assertEmpty(
+        $this->assertSame(
+            [],
             $failedToAssertViolations,
             \sprintf('Expected violation(s) for constraint(s) %s to be raised by compound.',
                 implode(', ', array_map(fn ($violation) => ($violation->getConstraint())::class, $failedToAssertViolations))

Tests/Constraints/WhenTest.php

@@ -61,7 +61,7 @@ public function testAttributes()
                 groups: ['Default', 'WhenTestWithAttributes'],
             ),
         ], $classConstraint->constraints);
-        self::assertEmpty($classConstraint->otherwise);
+        self::assertSame([], $classConstraint->otherwise);
 
         [$fooConstraint] = $metadata->properties['foo']->getConstraints();
 
@@ -71,7 +71,7 @@ public function testAttributes()
             new NotNull(groups: ['Default', 'WhenTestWithAttributes']),
             new NotBlank(groups: ['Default', 'WhenTestWithAttributes']),
         ], $fooConstraint->constraints);
-        self::assertEmpty($fooConstraint->otherwise);
+        self::assertSame([], $fooConstraint->otherwise);
         self::assertSame(['Default', 'WhenTestWithAttributes'], $fooConstraint->groups);
 
         [$barConstraint] = $metadata->properties['bar']->getConstraints();
@@ -82,15 +82,15 @@ public function testAttributes()
             new NotNull(groups: ['foo']),
             new NotBlank(groups: ['foo']),
         ], $barConstraint->constraints);
-        self::assertEmpty($barConstraint->otherwise);
+        self::assertSame([], $barConstraint->otherwise);
         self::assertSame(['foo'], $barConstraint->groups);
 
         [$quxConstraint] = $metadata->properties['qux']->getConstraints();
 
         self::assertInstanceOf(When::class, $quxConstraint);
         self::assertSame('true', $quxConstraint->expression);
         self::assertEquals([new NotNull(groups: ['foo'])], $quxConstraint->constraints);
-        self::assertEmpty($quxConstraint->otherwise);
+        self::assertSame([], $quxConstraint->otherwise);
         self::assertSame(['foo'], $quxConstraint->groups);
 
         [$bazConstraint] = $metadata->getters['baz']->getConstraints();
@@ -101,7 +101,7 @@ public function testAttributes()
             new NotNull(groups: ['Default', 'WhenTestWithAttributes']),
             new NotBlank(groups: ['Default', 'WhenTestWithAttributes']),
         ], $bazConstraint->constraints);
-        self::assertEmpty($bazConstraint->otherwise);
+        self::assertSame([], $bazConstraint->otherwise);
         self::assertSame(['Default', 'WhenTestWithAttributes'], $bazConstraint->groups);
 
         [$quuxConstraint] = $metadata->properties['quux']->getConstraints();
@@ -135,7 +135,7 @@ public function testAttributesWithClosure()
                 groups: ['Default', 'WhenTestWithClosure'],
             ),
         ], $classConstraint->constraints);
-        self::assertEmpty($classConstraint->otherwise);
+        self::assertSame([], $classConstraint->otherwise);
 
         [$fooConstraint] = $metadata->properties['foo']->getConstraints();
 
@@ -145,7 +145,7 @@ public function testAttributesWithClosure()
             new NotNull(groups: ['Default', 'WhenTestWithClosure']),
             new NotBlank(groups: ['Default', 'WhenTestWithClosure']),
         ], $fooConstraint->constraints);
-        self::assertEmpty($fooConstraint->otherwise);
+        self::assertSame([], $fooConstraint->otherwise);
         self::assertSame(['Default', 'WhenTestWithClosure'], $fooConstraint->groups);
     }
 }

Tests/Mapping/Loader/PropertyInfoLoaderTest.php

@@ -214,7 +214,7 @@ public function getTypes(string $class, string $property, array $context = []):
         $this->assertInstanceOf(Iban::class, $alreadyPartiallyMappedCollectionConstraints[0]->constraints[1]);
 
         $readOnlyMetadata = $classMetadata->getPropertyMetadata('readOnly');
-        $this->assertEmpty($readOnlyMetadata);
+        $this->assertSame([], $readOnlyMetadata);
 
         /** @var PropertyMetadata[] $noAutoMappingMetadata */
         $noAutoMappingMetadata = $classMetadata->getPropertyMetadata('noAutoMapping');
@@ -298,7 +298,7 @@ public function getTypes(string $class, string $property, array $context = []):
 
         /** @var ClassMetadata $classMetadata */
         $classMetadata = $validator->getMetadataFor(new PropertyInfoLoaderNoAutoMappingEntity());
-        $this->assertEmpty($classMetadata->getPropertyMetadata('string'));
+        $this->assertSame([], $classMetadata->getPropertyMetadata('string'));
         $this->assertCount(2, $classMetadata->getPropertyMetadata('autoMappingExplicitlyEnabled')[0]->constraints);
         $this->assertSame(AutoMappingStrategy::ENABLED, $classMetadata->getPropertyMetadata('autoMappingExplicitlyEnabled')[0]->getAutoMappingStrategy());
     }