[Validator] Only handle numeric values in DivisibleBy

Author: fancyweb

Constraints/DivisibleByValidator.php

@@ -11,6 +11,8 @@
 
 namespace Symfony\Component\Validator\Constraints;
 
+use Symfony\Component\Validator\Exception\UnexpectedValueException;
+
 /**
  * Validates that values are a multiple of the given number.
  *
@@ -23,6 +25,14 @@ class DivisibleByValidator extends AbstractComparisonValidator
      */
     protected function compareValues($value1, $value2)
     {
+        if (!is_numeric($value1)) {
+            throw new UnexpectedValueException($value1, 'numeric');
+        }
+
+        if (!is_numeric($value2)) {
+            throw new UnexpectedValueException($value2, 'numeric');
+        }
+
         if (!$value2 = abs($value2)) {
             return false;
         }

Tests/Constraints/DivisibleByValidatorTest.php

@@ -13,6 +13,7 @@
 
 use Symfony\Component\Validator\Constraints\DivisibleBy;
 use Symfony\Component\Validator\Constraints\DivisibleByValidator;
+use Symfony\Component\Validator\Exception\UnexpectedValueException;
 
 /**
  * @author Colin O'Dell <[email protected]>
@@ -75,4 +76,25 @@ public function provideInvalidComparisons()
             ['22', '"22"', '10', '"10"', 'string'],
         ];
     }
+
+    /**
+     * @dataProvider throwsOnNonNumericValuesProvider
+     */
+    public function testThrowsOnNonNumericValues(string $expectedGivenType, $value, $comparedValue)
+    {
+        $this->expectException(UnexpectedValueException::class);
+        $this->expectExceptionMessage(sprintf('Expected argument of type "numeric", "%s" given', $expectedGivenType));
+
+        $this->validator->validate($value, $this->createConstraint([
+            'value' => $comparedValue,
+        ]));
+    }
+
+    public function throwsOnNonNumericValuesProvider()
+    {
+        return [
+            [\stdClass::class, 2, new \stdClass()],
+            [\ArrayIterator::class, new \ArrayIterator(), 12],
+        ];
+    }
 }