Replace more docblocks by type-hints

Author: nicolas-grekas

ConstraintViolation.php

@@ -49,7 +49,7 @@ class ConstraintViolation implements ConstraintViolationInterface
      *                                         caused the violation
      * @param mixed           $cause           The cause of the violation
      */
-    public function __construct($message, $messageTemplate, array $parameters, $root, $propertyPath, $invalidValue, $plural = null, $code = null, Constraint $constraint = null, $cause = null)
+    public function __construct(?string $message, ?string $messageTemplate, array $parameters, $root, ?string $propertyPath, $invalidValue, int $plural = null, $code = null, Constraint $constraint = null, $cause = null)
     {
         $this->message = $message;
         $this->messageTemplate = $messageTemplate;

Constraints/EmailValidator.php

@@ -25,10 +25,7 @@ class EmailValidator extends ConstraintValidator
 {
     private $isStrict;
 
-    /**
-     * @param bool $strict
-     */
-    public function __construct($strict = false)
+    public function __construct(bool $strict = false)
     {
         $this->isStrict = $strict;
     }
@@ -111,24 +108,16 @@ public function validate($value, Constraint $constraint)
 
     /**
      * Check DNS Records for MX type.
-     *
-     * @param string $host Host
-     *
-     * @return bool
      */
-    private function checkMX($host)
+    private function checkMX(string $host): bool
     {
         return '' !== $host && checkdnsrr($host, 'MX');
     }
 
     /**
      * Check if one of MX, A or AAAA DNS RR exists.
-     *
-     * @param string $host Host
-     *
-     * @return bool
      */
-    private function checkHost($host)
+    private function checkHost(string $host): bool
     {
         return '' !== $host && ($this->checkMX($host) || (checkdnsrr($host, 'A') || checkdnsrr($host, 'AAAA')));
     }

Constraints/File.php

@@ -59,6 +59,9 @@ class File extends Constraint
 
     protected $maxSize;
 
+    /**
+     * {@inheritdoc}
+     */
     public function __construct($options = null)
     {
         parent::__construct($options);

Context/ExecutionContext.php

@@ -140,7 +140,7 @@ class ExecutionContext implements ExecutionContextInterface
      * @internal Called by {@link ExecutionContextFactory}. Should not be used
      *           in user code.
      */
-    public function __construct(ValidatorInterface $validator, $root, TranslatorInterface $translator, $translationDomain = null)
+    public function __construct(ValidatorInterface $validator, $root, TranslatorInterface $translator, string $translationDomain = null)
     {
         $this->validator = $validator;
         $this->root = $root;

Context/ExecutionContextFactory.php

@@ -34,7 +34,7 @@ class ExecutionContextFactory implements ExecutionContextFactoryInterface
      *                                               use for translating
      *                                               violation messages
      */
-    public function __construct(TranslatorInterface $translator, $translationDomain = null)
+    public function __construct(TranslatorInterface $translator, string $translationDomain = null)
     {
         $this->translator = $translator;
         $this->translationDomain = $translationDomain;

DependencyInjection/AddConstraintValidatorsPass.php

@@ -25,7 +25,7 @@ class AddConstraintValidatorsPass implements CompilerPassInterface
     private $validatorFactoryServiceId;
     private $constraintValidatorTag;
 
-    public function __construct($validatorFactoryServiceId = 'validator.validator_factory', $constraintValidatorTag = 'validator.constraint_validator')
+    public function __construct(string $validatorFactoryServiceId = 'validator.validator_factory', string $constraintValidatorTag = 'validator.constraint_validator')
     {
         $this->validatorFactoryServiceId = $validatorFactoryServiceId;
         $this->constraintValidatorTag = $constraintValidatorTag;

DependencyInjection/AddValidatorInitializersPass.php

@@ -24,7 +24,7 @@ class AddValidatorInitializersPass implements CompilerPassInterface
     private $builderService;
     private $initializerTag;
 
-    public function __construct($builderService = 'validator.builder', $initializerTag = 'validator.initializer')
+    public function __construct(string $builderService = 'validator.builder', string $initializerTag = 'validator.initializer')
     {
         $this->builderService = $builderService;
         $this->initializerTag = $initializerTag;

Exception/InvalidOptionsException.php

@@ -15,7 +15,7 @@ class InvalidOptionsException extends ValidatorException
 {
     private $options;
 
-    public function __construct($message, array $options)
+    public function __construct(string $message, array $options)
     {
         parent::__construct($message);
 

Exception/MissingOptionsException.php

@@ -15,7 +15,7 @@ class MissingOptionsException extends ValidatorException
 {
     private $options;
 
-    public function __construct($message, array $options)
+    public function __construct(string $message, array $options)
     {
         parent::__construct($message);
 

Exception/UnexpectedTypeException.php

@@ -13,7 +13,7 @@
 
 class UnexpectedTypeException extends ValidatorException
 {
-    public function __construct($value, $expectedType)
+    public function __construct($value, string $expectedType)
     {
         parent::__construct(sprintf('Expected argument of type "%s", "%s" given', $expectedType, is_object($value) ? get_class($value) : gettype($value)));
     }